Bug 196265

Summary: Add basic layout test coverage for File Picker on iOS
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, conrad_shultz, ggaren, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196205
https://bugs.webkit.org/show_bug.cgi?id=213314
Bug Depends on: 196405    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-03-26 12:19:43 PDT
Add basic layout test coverage for File Picker on iOS.
Attachments
Patch (20.68 KB, patch)
2019-03-26 12:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.69 KB, patch)
2019-03-26 12:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.78 KB, patch)
2019-03-26 14:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-03-26 12:21:42 PDT
Created attachment 365984 [details] Patch
Chris Dumez
Comment 2 2019-03-26 12:49:42 PDT
Created attachment 365989 [details] Patch
Wenson Hsieh
Comment 3 2019-03-26 14:31:33 PDT
Comment on attachment 365989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365989&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7018 > + auto* result = @{ userInterfaceItem: [_fileUploadPanel currentAvailableActionTitles] }; Nit - would be cleaner just to return @{ ~ } > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:53 > +static void overridePresentViewController() Nit - maybe overridePresentViewControllerOrPopover, since it's used for both purposes? > LayoutTests/fast/forms/ios/file-upload-panel.html:62 > + UIHelper.activateElement(testInput).then(() => { > + getFileUploadPickerMenuItems().then((_items) => { > + items = _items; > + shouldBeTrue("areArraysEqual(items, " + expectedMenuItems + ")"); > + debug(""); > + dismissFilePicker().then(() => { resolve(); }); > + }); > + }); Nit - IMO this function could be made cleaner using async - await, but either way it's fine.
Chris Dumez
Comment 4 2019-03-26 14:40:30 PDT
Created attachment 365999 [details] Patch
Chris Dumez
Comment 5 2019-03-26 16:24:40 PDT
Comment on attachment 365999 [details] Patch Clearing flags on attachment: 365999 Committed r243523: <https://trac.webkit.org/changeset/243523>
Chris Dumez
Comment 6 2019-03-26 16:24:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-03-26 16:25:18 PDT
<rdar://problem/49299305>
Note You need to log in before you can comment on or make changes to this bug.