Bug 193475

Summary: VisualViewport API should be updated upon opening of keyboard
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebCore Misc.Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192564
Bug Depends on:    
Bug Blocks: 170982    
Attachments:
Description Flags
Fixes the bug simon.fraser: review+

Ryosuke Niwa
Reported 2019-01-15 17:33:01 PST
When the user had opened software keyboard, the visual viewport width & height should be updated and resize event should be dispatched.
Attachments
Fixes the bug (9.54 KB, patch)
2019-01-15 17:46 PST, Ryosuke Niwa 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-01-15 17:46:53 PST
Created attachment 359234 [details] Fixes the bug
Simon Fraser (smfr)
Comment 2 2019-01-15 19:06:02 PST
Comment on attachment 359234 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=359234&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3044 > + frameView.didUpdateViewportOverrideRects(); Do we know that the visual viewport actually changed? Perhaps setVisualViewportOverrideRect() should return a bool and we only call this when it changes.
Ryosuke Niwa
Comment 3 2019-01-15 19:08:09 PST
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 359234 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359234&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3044 > > + frameView.didUpdateViewportOverrideRects(); > > Do we know that the visual viewport actually changed? Perhaps > setVisualViewportOverrideRect() should return a bool and we only call this > when it changes. VisualViewport::update checks whether the values had changed then schedule resize event, etc... only if the values had changed.
Ryosuke Niwa
Comment 4 2019-01-15 19:18:50 PST
Thanks for the review!
Radar WebKit Bug Importer
Comment 5 2019-01-15 19:19:41 PST
<rdar://problem/47305687>
Ryosuke Niwa
Comment 6 2019-01-15 19:36:02 PST
Committed r240027: <https://trac.webkit.org/changeset/240027>
Sam Weinig
Comment 7 2019-01-18 08:58:50 PST
Comment on attachment 359234 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=359234&action=review > Source/WebCore/page/FrameView.h:596 > +#if PLATFORM(IOS_FAMILY) Can we use a more fine grained #ifdef here? Perhaps something like #if SUPPORTS(VIEWPORTS) or something akin to that?
Ryosuke Niwa
Comment 8 2019-01-18 20:28:22 PST
(In reply to Sam Weinig from comment #7) > Comment on attachment 359234 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359234&action=review > > > Source/WebCore/page/FrameView.h:596 > > +#if PLATFORM(IOS_FAMILY) > > Can we use a more fine grained #ifdef here? Perhaps something like #if > SUPPORTS(VIEWPORTS) or something akin to that? I think we can in theory but the code I'm adding is pretty specific to iOS, and as far as I can tell, no other port support this.
Note You need to log in before you can comment on or make changes to this bug.