Bug 192346

Summary: Web Inspector: Audit: save the expanded state of test groups
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192107
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-12-03 19:10:24 PST
<https://webkit.org/b/192107> removed the auto-expanding of groups, but we should actually auto-expand if the user had previously done so (similar to resources).
Attachments
Patch (2.54 KB, patch)
2018-12-03 19:37 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2018-12-03 20:57 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-03 19:10:49 PST
<rdar://problem/46440703>
Radar WebKit Bug Importer
Comment 2 2018-12-03 19:10:51 PST
<rdar://problem/46440704>
Devin Rousso
Comment 3 2018-12-03 19:37:16 PST
Created attachment 356449 [details] Patch
Matt Baker
Comment 4 2018-12-03 20:32:21 PST
Comment on attachment 356449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review r=me > Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54 > + this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false); How about using a template string? `audit-tree-element-${this.representedObject.name}-expanded`
Devin Rousso
Comment 5 2018-12-03 20:57:05 PST
Created attachment 356454 [details] Patch
WebKit Commit Bot
Comment 6 2018-12-03 21:46:12 PST
The commit-queue encountered the following flaky tests while processing attachment 356454 [details]: inspector/model/auditTestCase.html bug 192350 (author: drousso@apple.com) http/tests/inspector/network/loadResource-insecure-resource.html bug 192351 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-12-03 21:46:21 PST
The commit-queue encountered the following flaky tests while processing attachment 356454 [details]: inspector/unit-tests/event-listener.html bug 192050 (authors: bburg@apple.com and drousso@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2018-12-03 22:01:24 PST
Comment on attachment 356454 [details] Patch Clearing flags on attachment: 356454 Committed r238843: <https://trac.webkit.org/changeset/238843>
WebKit Commit Bot
Comment 9 2018-12-03 22:01:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.