Bug 192217

Summary:

CSS Painting API should scale display list when drawing

Product:

WebKit

Reporter:

Justin Michaud <justin_michaud>

Component:

Layout and Rendering

Assignee:

Justin Michaud <justin_michaud>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

190217

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	none

Justin Michaud

Reported 2018-11-29 22:34:06 PST

When the user zooms in on a custom paint element, it should be sharp. This should not be visible to the paint worklet.

Attachments
Patch (3.82 KB, patch) 2018-11-29 22:37 PST, Justin Michaud	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.75 MB, application/zip) 2018-11-30 02:58 PST, EWS Watchlist	no flags	Details
Patch (10.62 KB, patch) 2018-11-30 14:48 PST, Justin Michaud	no flags	Details Formatted Diff Diff
Patch (10.52 KB, patch) 2018-11-30 18:12 PST, Justin Michaud	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Justin Michaud

Comment 1 2018-11-29 22:37:54 PST

Created attachment 356142 [details] Patch

EWS Watchlist

Comment 2 2018-11-30 02:58:38 PST Comment hidden (obsolete)

Comment on attachment 356142 [details] Patch Attachment 356142 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10212334 New failing tests: fast/css-custom-paint/registerPaintBindings.html fast/css-custom-paint/properties.html fast/css-custom-paint/worklet.html

EWS Watchlist

Comment 3 2018-11-30 02:58:40 PST Comment hidden (obsolete)

Created attachment 356167 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 4 2018-11-30 10:19:11 PST

Comment on attachment 356142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356142&action=review > Source/WebCore/ChangeLog:9 > + There are no tests for this because I do not know how to make tests that would not be flaky. Why? > Source/WebCore/html/CustomPaintCanvas.cpp:114 > + m_destinationGraphicsContext = &image->context(); > + m_destinationGraphicsContext->translate(-ctx->clipBounds().location()); > + if (m_context) > + m_context->paintRenderingResultsToCanvas(); > + m_destinationGraphicsContext = nullptr; This is weird. Don't have the m_destinationGraphicsContext data member; just pass the destination context around.

Justin Michaud

Comment 5 2018-11-30 14:48:03 PST

Created attachment 356243 [details] Patch

Justin Michaud

Comment 6 2018-11-30 18:12:15 PST

Created attachment 356278 [details] Patch

WebKit Commit Bot

Comment 7 2018-12-03 20:03:22 PST

Comment on attachment 356278 [details] Patch Clearing flags on attachment: 356278 Committed r238839: <https://trac.webkit.org/changeset/238839>

WebKit Commit Bot

Comment 8 2018-12-03 20:03:24 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-12-03 20:04:30 PST

<rdar://problem/46441508>

Note You need to log in before you can comment on or make changes to this bug.