Bug 191727

Summary:

Web Inspector: Audit: minor style improvements

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

190754

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Patch	none
Patch	none

Devin Rousso

Reported 2018-11-15 17:18:52 PST

- horizontally align the right-side items - increase the horizontal space between test case result icon and title - change description color - clear test results on navigation - capture the CSS path when the test finishes, not on export And possibly more :)

Attachments
Patch (12.43 KB, patch) 2018-11-15 17:22 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (12.61 KB, patch) 2018-11-15 17:25 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.54 MB, application/zip) 2018-11-15 18:19 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.01 MB, application/zip) 2018-11-15 18:36 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (2.19 MB, application/zip) 2018-11-15 19:19 PST, EWS Watchlist	no flags	Details
Patch (15.28 KB, patch) 2018-11-16 10:46 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (15.28 KB, patch) 2018-11-16 17:21 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-11-15 17:22:32 PST

Created attachment 355001 [details] Patch

Devin Rousso

Comment 2 2018-11-15 17:25:28 PST

Created attachment 355002 [details] Patch

Devin Rousso

Comment 3 2018-11-15 17:26:14 PST

One thing I was also thinking about adding (but not sure of) is possibly some warning when viewing a saved result after navigation explaining that the DOM nodes shown (if any) aren't live anymore, and won't respond to any interactions. Considering how we rehydrate DOM nodes when importing, maybe we should attempt to rehydrate when navigating as well, but only if the URL stays the same (it would change to show the CSS path otherwise). Thoughts?

EWS Watchlist

Comment 4 2018-11-15 18:19:19 PST Comment hidden (obsolete)

Comment on attachment 355002 [details] Patch Attachment 355002 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10010829 New failing tests: inspector/audit/data-domNodes.html

EWS Watchlist

Comment 5 2018-11-15 18:19:20 PST Comment hidden (obsolete)

Created attachment 355009 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-11-15 18:36:26 PST Comment hidden (obsolete)

Comment on attachment 355002 [details] Patch Attachment 355002 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10010967 New failing tests: inspector/audit/data-domNodes.html

EWS Watchlist

Comment 7 2018-11-15 18:36:27 PST Comment hidden (obsolete)

Created attachment 355011 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-11-15 19:19:15 PST Comment hidden (obsolete)

Comment on attachment 355002 [details] Patch Attachment 355002 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10011134 New failing tests: inspector/audit/data-domNodes.html

EWS Watchlist

Comment 9 2018-11-15 19:19:16 PST Comment hidden (obsolete)

Created attachment 355014 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Devin Rousso

Comment 10 2018-11-16 10:46:20 PST

Created attachment 355077 [details] Patch

Joseph Pecoraro

Comment 11 2018-11-16 17:18:17 PST

Comment on attachment 355077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355077&action=review rs=me > Source/WebInspectorUI/ChangeLog:23 > + > + Style: extra newline.

Devin Rousso

Comment 12 2018-11-16 17:21:54 PST

Created attachment 355168 [details] Patch

WebKit Commit Bot

Comment 13 2018-11-16 18:10:52 PST

Comment on attachment 355168 [details] Patch Clearing flags on attachment: 355168 Committed r238333: <https://trac.webkit.org/changeset/238333>