Bug 191460

Summary:

Import the Flexbox test suite from the W3C Web Platform Tests

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

Layout and Rendering

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, clopez, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=211762

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Javier Fernandez

Reported 2018-11-09 03:41:32 PST

We should import the Flexbox test suite, but also, a few tests depend on reference files that belong to such suite. I'll skip any of those dependent tests while this bug is not fixed.

Attachments
Patch (1.88 MB, patch) 2020-04-22 07:47 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.19 MB, patch) 2020-05-11 21:21 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.91 MB, patch) 2020-05-13 19:56 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.91 MB, patch) 2020-05-14 06:59 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.91 MB, patch) 2020-05-18 14:54 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.91 MB, patch) 2020-05-18 17:36 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (2.98 MB, patch) 2020-05-19 04:39 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2020-04-22 07:47:50 PDT

Created attachment 397188 [details] Patch Trying EWS. Ignore

Carlos Alberto Lopez Perez

Comment 2 2020-05-11 21:21:45 PDT

Created attachment 399095 [details] Patch test EWS, ignore

Carlos Alberto Lopez Perez

Comment 3 2020-05-13 19:56:36 PDT

Created attachment 399326 [details] Patch test EWS, ignore

Carlos Alberto Lopez Perez

Comment 4 2020-05-14 06:59:41 PDT

Created attachment 399357 [details] Patch test EWS, ignore

Manuel Rego Casasnovas

Comment 5 2020-05-14 15:45:19 PDT

Comment on attachment 399357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399357&action=review > LayoutTests/ChangeLog:8 > + This imports WPT css-flexbox and de-deplicates flexbox tests Typo: s/de-deplicates/deduplicates/ > LayoutTests/ChangeLog:10 > + This its the complete list of tests de-duplicated. Typo: I believe hyphen is not needed, anyway it should be consistent with the one above.

Carlos Alberto Lopez Perez

Comment 6 2020-05-18 14:54:43 PDT

Created attachment 399676 [details] Patch Test EWS again. Hopefully green

Carlos Alberto Lopez Perez

Comment 7 2020-05-18 17:36:43 PDT

Created attachment 399688 [details] Patch test EWS

Carlos Alberto Lopez Perez

Comment 8 2020-05-18 21:12:08 PDT

Comment on attachment 399688 [details] Patch EWS green! asking for review now Note: i think the style error is not valid.

Sergio Villar Senin

Comment 9 2020-05-19 03:29:13 PDT

Comment on attachment 399688 [details] Patch Fix the typo in the ChangeLog (deplicates->duplicates) before landing.

Carlos Alberto Lopez Perez

Comment 10 2020-05-19 04:39:02 PDT

Created attachment 399730 [details] Patch patch for landing

EWS

Comment 11 2020-05-19 07:52:09 PDT

Committed r261859: <https://trac.webkit.org/changeset/261859> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399730 [details].

Radar WebKit Bug Importer

Comment 12 2020-05-19 07:53:18 PDT

<rdar://problem/63394960>

Note You need to log in before you can comment on or make changes to this bug.