Bug 190854

Summary: Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, inspector-bugzilla-changes, kondapallykalyan, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch
none
Patch none

Devin Rousso
Reported 2018-10-23 18:39:03 PDT
This includes changes to `width` and `height`, and maybe `transferToImageBitmap`.
Attachments
Patch (59.26 KB, patch)
2018-10-28 15:49 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (900.01 KB, image/png)
2018-10-28 15:50 PDT, Devin Rousso 		no flags
Details
Patch (58.65 KB, patch)
2018-10-28 15:56 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (39.47 KB, patch)
2018-11-03 13:43 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-28 15:49:32 PDT
Created attachment 353264 [details] Patch
Devin Rousso
Comment 2 2018-10-28 15:50:39 PDT
Created attachment 353265 [details] [Image] After Patch is applied
Devin Rousso
Comment 3 2018-10-28 15:56:05 PDT
Created attachment 353266 [details] Patch Whoops. Forgot to stage a few things before uploading.
Matt Baker
Comment 4 2018-11-02 10:40:15 PDT
Comment on attachment 353266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353266&action=review > Source/WebInspectorUI/ChangeLog:17 > + `context`'s `canvas` instead of directly to the `context`). The context replacers for all three context types are the same, but are ordered differently. Why is this? Why have these values at all if they are always "canvas"? > Source/WebCore/bindings/js/CallTracer.cpp:35 > +void CallTracer::recordCanvasAction(HTMLCanvasElement& canvasElement, const String& name, Vector<RecordCanvasActionVariant>&& parameters) Can we pass HTMLCanvasElement as a const reference? CanvasBase::renderingContent() is a const member function that returns a non-const pointer, so you shouldn't need to make a bunch of other stuff const to plumb the value through to InspectorInstrumentation.
Devin Rousso
Comment 5 2018-11-03 13:43:55 PDT
Created attachment 353781 [details] Patch
Matt Baker
Comment 6 2018-11-03 15:58:35 PDT
Comment on attachment 353781 [details] Patch r=me
WebKit Commit Bot
Comment 7 2018-11-03 16:24:42 PDT
Comment on attachment 353781 [details] Patch Clearing flags on attachment: 353781 Committed r237777: <https://trac.webkit.org/changeset/237777>
WebKit Commit Bot
Comment 8 2018-11-03 16:24:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-03 16:25:20 PDT
<rdar://problem/45787282>
Note You need to log in before you can comment on or make changes to this bug.