Bug 189486

Summary:

Header parsing for experimental and internal debug features

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, rniwa, ryanhaddad, thorton, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

189442

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews115 for mac-sierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none

Dean Jackson

Reported 2018-09-10 15:40:21 PDT

Header parsing for experimental and internal debug features

Attachments
Patch (183.63 KB, patch) 2018-09-10 15:45 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (194.56 KB, patch) 2018-09-11 17:32 PDT, Dean Jackson	thorton: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-sierra (3.67 MB, application/zip) 2018-09-11 19:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (38.80 MB, application/zip) 2018-09-11 20:18 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-sierra (2.28 MB, application/zip) 2018-09-11 20:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.10 MB, application/zip) 2018-09-11 21:08 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-09-10 15:40:55 PDT

<rdar://problem/44320618>

Dean Jackson

Comment 2 2018-09-10 15:41:21 PDT

Relies on https://bugs.webkit.org/show_bug.cgi?id=189442

Dean Jackson

Comment 3 2018-09-10 15:45:03 PDT

Created attachment 349340 [details] Patch

Dean Jackson

Comment 4 2018-09-11 17:32:33 PDT

Created attachment 349497 [details] Patch

EWS Watchlist

Comment 5 2018-09-11 19:03:47 PDT

Comment on attachment 349497 [details] Patch Attachment 349497 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9182425 New failing tests: webanimations/accelerated-transition-interrupted-on-composited-element.html

EWS Watchlist

Comment 6 2018-09-11 19:03:49 PDT

Created attachment 349501 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-09-11 20:18:33 PDT

Comment on attachment 349497 [details] Patch Attachment 349497 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9183884 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-09-11 20:18:35 PDT

Created attachment 349511 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 9 2018-09-11 20:54:25 PDT

Comment on attachment 349497 [details] Patch Attachment 349497 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9185205 New failing tests: webanimations/accelerated-transition-interrupted-on-composited-element.html

EWS Watchlist

Comment 10 2018-09-11 20:54:26 PDT

Created attachment 349515 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-09-11 21:08:11 PDT

Comment on attachment 349497 [details] Patch Attachment 349497 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9185483 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 12 2018-09-11 21:08:13 PDT

Created attachment 349517 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Dean Jackson

Comment 13 2018-09-12 13:59:54 PDT

Committed r235948: <https://trac.webkit.org/changeset/235948>

Truitt Savell

Comment 14 2018-09-12 15:24:13 PDT

This revision https://trac.webkit.org/changeset/235948/webkit has caused over 100 test failures: https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r235948%20(7382)/results.html https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/7382 Is this a quick fix?

Truitt Savell

Comment 15 2018-09-13 09:01:22 PDT

The test edited in https://trac.webkit.org/changeset/235964/webkit is a constant image failure History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Fanimations%2Fduplicate-keys.html Diff: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r235970%20(11641)/legacy-animation-engine/animations/duplicate-keys-diffs.html Looks like the image has accidentally been shifted up on the page.

Truitt Savell

Comment 16 2018-09-13 10:01:51 PDT

This test: fast/animation/css-animation-resuming-when-visible-with-style-change2.html is highly flakey after https://trac.webkit.org/changeset/235948/webkit confirmed flakiness using command: run-webkit-tests --root testbuild-235948 fast/animation/css-animation-resuming-when-visible-with-style-change2.html --iterations 100 -f running this command on r235947 yields no failures. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fanimation%2Fcss-animation-resuming-when-visible-with-style-change2.html Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r235973%20(6728)/fast/animation/css-animation-resuming-when-visible-with-style-change2-pretty-diff.html

Note You need to log in before you can comment on or make changes to this bug.