Bug 188336

Summary:

HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, koivisto, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

154907, 183931, 187319

Attachments:

Description	Flags
Fixes the bug	none
Added a missing change log	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Ryosuke Niwa

Reported 2018-08-05 18:42:47 PDT

HTML parser should be pushing & popping from the custom element reactions stack: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token

Attachments
Fixes the bug (4.20 KB, patch) 2018-08-05 18:59 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Added a missing change log (5.03 KB, patch) 2018-08-05 19:00 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (35.99 KB, patch) 2018-08-07 14:03 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (33.08 KB, patch) 2018-08-07 14:06 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (33.08 KB, patch) 2018-08-07 14:06 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2018-08-05 18:59:47 PDT

Created attachment 346607 [details] Fixes the bug

Ryosuke Niwa

Comment 2 2018-08-05 19:00:51 PDT

Created attachment 346608 [details] Added a missing change log

Radar WebKit Bug Importer

Comment 3 2018-08-05 19:01:45 PDT

<rdar://problem/42954915>

Ryosuke Niwa

Comment 4 2018-08-05 19:10:49 PDT

Comment on attachment 346608 [details] Added a missing change log View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:216 > + m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData); Note that the insertion step doesn't need to be split because there is no way to affect the list of open elements in the parser once we forbid document.open/write in the bug 187319.

Frédéric Wang (:fredw)

Comment 5 2018-08-05 21:41:23 PDT

Comment on attachment 346608 [details] Added a missing change log View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review > Source/WebCore/ChangeLog:13 > + is set or not since the precense of an element queue should not be observable in the case where we're constructing nit: presence

Ryosuke Niwa

Comment 6 2018-08-06 00:51:15 PDT

Did you mean to r+ the patch with that comment?

Frédéric Wang (:fredw)

Comment 7 2018-08-06 00:57:05 PDT

(In reply to Ryosuke Niwa from comment #6) > Did you mean to r+ the patch with that comment? The patch looks good to me, but maybe someone else should review since I worked on this issue in bug 188190.

Ryosuke Niwa

Comment 8 2018-08-06 00:58:42 PDT

(In reply to Frédéric Wang (:fredw) from comment #7) > (In reply to Ryosuke Niwa from comment #6) > > Did you mean to r+ the patch with that comment? > > The patch looks good to me, but maybe someone else should review since I > worked on this issue in bug 188190. Fair enough although this code change is quite bit different from what you made in that bug.

Frédéric Wang (:fredw)

Comment 9 2018-08-06 01:03:58 PDT

(In reply to Ryosuke Niwa from comment #8) > (In reply to Frédéric Wang (:fredw) from comment #7) > > (In reply to Ryosuke Niwa from comment #6) > > > Did you mean to r+ the patch with that comment? > > > > The patch looks good to me, but maybe someone else should review since I > > worked on this issue in bug 188190. > > Fair enough although this code change is quite bit different from what you > made in that bug. Right, let's take this then.

Ryosuke Niwa

Comment 10 2018-08-06 10:45:44 PDT

Committed r234608: <https://trac.webkit.org/changeset/234608>

Ryosuke Niwa

Comment 11 2018-08-07 14:02:58 PDT

Reopening to attach new patch.

Ryosuke Niwa

Comment 12 2018-08-07 14:03:00 PDT

Created attachment 346728 [details] Patch for landing

Ryosuke Niwa

Comment 13 2018-08-07 14:03:39 PDT

Comment on attachment 346728 [details] Patch for landing Oops, wrong bug.

Ryosuke Niwa

Comment 14 2018-08-07 14:06:11 PDT

Created attachment 346730 [details] Patch for landing

Ryosuke Niwa

Comment 15 2018-08-07 14:06:51 PDT

Created attachment 346731 [details] Patch for landing

Ryosuke Niwa

Comment 16 2018-08-07 14:07:17 PDT

Comment on attachment 346731 [details] Patch for landing Ugh... wrong bug again.

Note You need to log in before you can comment on or make changes to this bug.