Bug 18641

Summary: SQUIRRELFISH: add support for error nodes
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 18624    
Attachments:
Description Flags
Proposed patch mjs: review+

Cameron Zwarich (cpst)
Reported 2008-04-20 16:08:35 PDT
SquirrelFish currently doesn't support AssignErrorNode, PrefixErrorNode, and PostfixErrorNode. This causes the JavaScriptCore test ecma/LexicalConventions/7.5-10-n.js to fail.
Attachments
Proposed patch (7.50 KB, patch)
2008-04-20 16:11 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-04-20 16:11:02 PDT
Created attachment 20709 [details] Proposed patch Here is a patch that implements support for error nodes. I tested with SunSpider and it showed no change. Should I break up lines with the long string constants so they are each on their own line?
Maciej Stachowiak
Comment 2 2008-04-20 16:15:19 PDT
Comment on attachment 20709 [details] Proposed patch Assuming this shows no sunspider regression, r=me.
Cameron Zwarich (cpst)
Comment 3 2008-04-20 16:36:48 PDT
Landed in r32283.
Note You need to log in before you can comment on or make changes to this bug.