Bug 185580

Summary: Implement SVGGeometryElement's isPointInFill and isPointInStroke
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, koivisto, rniwa, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184767    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Patch for landing
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch for landing
none
Archive of layout-test-results from webkit-cq-03 for mac-sierra
none
Patch for landing none

Dirk Schulze
Reported 2018-05-12 04:17:57 PDT
Implement isPointInFill and isPointInStroke for SVGGeometryElement interface from SVG2. https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement
Attachments
Patch (31.90 KB, patch)
2018-05-12 04:32 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.80 MB, application/zip)
2018-05-12 10:23 PDT, EWS Watchlist 		no flags
Details
Patch for landing (32.40 KB, patch)
2018-05-12 22:48 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.23 MB, application/zip)
2018-05-12 23:53 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.76 MB, application/zip)
2018-05-12 23:59 PDT, EWS Watchlist 		no flags
Details
Patch for landing (32.32 KB, patch)
2018-05-13 00:16 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-sierra (2.24 MB, application/zip)
2018-05-13 01:22 PDT, WebKit Commit Bot 		no flags
Details
Patch for landing (32.32 KB, patch)
2018-05-13 01:47 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2018-05-12 04:32:51 PDT
Created attachment 340249 [details] Patch
Antti Koivisto
Comment 2 2018-05-12 06:53:27 PDT
Comment on attachment 340249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340249&action=review > Source/WebCore/rendering/svg/RenderSVGRect.h:53 > + bool shapeDependentStrokeContains(const FloatPoint&, bool isInLocalCoordinateSystem = false) override; How about enum class CoordinateSystem { Global, Local } or similar? Booleans can be confusing in call sites.
EWS Watchlist
Comment 3 2018-05-12 10:23:22 PDT
Comment on attachment 340249 [details] Patch Attachment 340249 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7661950 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 4 2018-05-12 10:23:32 PDT
Created attachment 340253 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Dirk Schulze
Comment 5 2018-05-12 22:48:26 PDT
Created attachment 340256 [details] Patch for landing
EWS Watchlist
Comment 6 2018-05-12 22:51:03 PDT
Attachment 340256 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/svg/RenderSVGShape.h:81: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGRect.h:53: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGPath.h:46: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGEllipse.h:47: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 7 2018-05-12 23:53:16 PDT
Comment on attachment 340256 [details] Patch for landing Attachment 340256 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7666215 New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml
EWS Watchlist
Comment 8 2018-05-12 23:53:17 PDT
Created attachment 340257 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 9 2018-05-12 23:59:53 PDT
Comment on attachment 340256 [details] Patch for landing Attachment 340256 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7666231 New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml
EWS Watchlist
Comment 10 2018-05-12 23:59:55 PDT
Created attachment 340258 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Dirk Schulze
Comment 11 2018-05-13 00:16:57 PDT
Created attachment 340259 [details] Patch for landing
WebKit Commit Bot
Comment 12 2018-05-13 01:22:23 PDT
Comment on attachment 340259 [details] Patch for landing Rejecting attachment 340259 [details] from commit-queue. New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml Full output: http://webkit-queues.webkit.org/results/7666653
WebKit Commit Bot
Comment 13 2018-05-13 01:22:25 PDT
Created attachment 340260 [details] Archive of layout-test-results from webkit-cq-03 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-sierra Platform: Mac OS X 10.12.6
Dirk Schulze
Comment 14 2018-05-13 01:47:48 PDT
Created attachment 340261 [details] Patch for landing
Dirk Schulze
Comment 15 2018-05-13 01:48:28 PDT
2 hick-ups after changing boolean to enum. Should be fixed now.
WebKit Commit Bot
Comment 16 2018-05-13 02:25:50 PDT
Comment on attachment 340261 [details] Patch for landing Clearing flags on attachment: 340261 Committed r231739: <https://trac.webkit.org/changeset/231739>
WebKit Commit Bot
Comment 17 2018-05-13 02:25:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 18 2018-05-13 02:27:14 PDT
<rdar://problem/40199770>
Note You need to log in before you can comment on or make changes to this bug.