Bug 182921

Summary: Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, CanvasFillStrokeStyles
Product: WebKit Reporter: Zan Dobersek <zan>
Component: CanvasAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cdumez, clord, commit-queue, dino, don.olmstead, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, hi, joepeck, koivisto, kondapallykalyan, rniwa, ross.kirsling, sam, thorton, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 182686    
Bug Blocks: 183720    
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2018-02-19 00:59:27 PST
OffscreenCanvas should be listed in the CanvasImageSource typedef in CanvasDrawImage.idl and CanvasFillStrokeStyles.idl. Implementation-wise, all of the code is already there, but it has to be broadened from covering only HTMLCanvasElement objects to covering CanvasBase instead.
Attachments
WIP patch (9.96 KB, patch)
2018-02-19 01:00 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (72.92 KB, patch)
2019-10-10 03:15 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (72.59 KB, patch)
2019-11-25 09:22 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-02-19 01:00:47 PST
Created attachment 334142 [details] WIP patch
Chris Lord
Comment 2 2019-10-10 03:15:57 PDT
Created attachment 380625 [details] Patch
Chris Lord
Comment 3 2019-11-25 09:22:19 PST
Created attachment 384301 [details] Patch
Antti Koivisto
Comment 4 2019-11-25 09:31:56 PST
Comment on attachment 384301 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-11-25 10:15:57 PST
Comment on attachment 384301 [details] Patch Clearing flags on attachment: 384301 Committed r252864: <https://trac.webkit.org/changeset/252864>
WebKit Commit Bot
Comment 6 2019-11-25 10:16:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-25 10:16:26 PST
<rdar://problem/57475517>
Note You need to log in before you can comment on or make changes to this bug.