Bug 182771

Summary: [WebAuthN] Implement PublicKeyCredential.isUserVerifyingPlatformAuthenticatorAvailable()
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jiewen Tan
Reported 2018-02-13 22:04:30 PST
Implement PublicKeyCredential.isUserVerifyingPlatformAuthenticatorAvailable() per https://www.w3.org/TR/webauthn/#isUserVerifyingPlatformAuthenticatorAvailable.
Attachments
Patch (57.62 KB, patch)
2018-02-13 22:19 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (54.37 KB, patch)
2018-02-15 14:38 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (54.53 KB, patch)
2018-02-15 16:52 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-02-13 22:04:59 PST
<rdar://problem/36459988>
Jiewen Tan
Comment 2 2018-02-13 22:19:00 PST
Created attachment 333769 [details] Patch
Brent Fulgham
Comment 3 2018-02-14 09:40:59 PST
Comment on attachment 333769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333769&action=review This looks good, but I think you should try to implement on macOS as well. The SDKs exist! r- because of lack of macOS support. > Source/WebCore/ChangeLog:13 > + Besides, it changes DeferredPromise to DOMPromiseDeferred<> for all CredentialsManagement and I would say, "In addition, it changes ..." > Source/WebKit/ChangeLog:9 > + This patch uitlizes LocalAuthentication Framework to determine if biometrics utilizes > Source/WebKit/ChangeLog:14 > + Corresponding macOS implementations are marked as unimplemented as a result. I don't think this is true. <https://developer.apple.com/documentation/localauthentication?language=objc> claims that it is present in iOS 8+ and macOS 10.10+ > Source/WebKit/UIProcess/CredentialManagement/ios/WebCredentialsMessengerProxyIOS.mm:44 > + LOG_ERROR("Couldn't evaluate policy: %@", error); This might be better as "Couldn't evaluate authentication with biometrics policy: %@" > Source/WebKit/UIProcess/CredentialManagement/mac/WebCredentialsMessengerProxyMac.mm:37 > + notImplemented(); I think this can be implemented, based on <https://developer.apple.com/documentation/localauthentication?language=objc>.
Jiewen Tan
Comment 4 2018-02-15 11:14:00 PST
Comment on attachment 333769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333769&action=review Thanks Brent for reviewing the patch. >> Source/WebCore/ChangeLog:13 >> + Besides, it changes DeferredPromise to DOMPromiseDeferred<> for all CredentialsManagement and > > I would say, "In addition, it changes ..." Fixed. >> Source/WebKit/ChangeLog:9 >> + This patch uitlizes LocalAuthentication Framework to determine if biometrics > > utilizes Fixed. >> Source/WebKit/ChangeLog:14 >> + Corresponding macOS implementations are marked as unimplemented as a result. > > I don't think this is true. <https://developer.apple.com/documentation/localauthentication?language=objc> claims that it is present in iOS 8+ and macOS 10.10+ Sure. I will try a TouchID equipped device and see what the real effect is. >> Source/WebKit/UIProcess/CredentialManagement/ios/WebCredentialsMessengerProxyIOS.mm:44 >> + LOG_ERROR("Couldn't evaluate policy: %@", error); > > This might be better as "Couldn't evaluate authentication with biometrics policy: %@" Fixed. >> Source/WebKit/UIProcess/CredentialManagement/mac/WebCredentialsMessengerProxyMac.mm:37 >> + notImplemented(); > > I think this can be implemented, based on <https://developer.apple.com/documentation/localauthentication?language=objc>. Ditto.
Jiewen Tan
Comment 5 2018-02-15 13:21:59 PST
Confirmed LocalAuthentication does distinguish TouchID equipped macs and TouchIDless ones.
Jiewen Tan
Comment 6 2018-02-15 14:38:55 PST
Created attachment 333949 [details] Patch
Jiewen Tan
Comment 7 2018-02-15 16:52:29 PST
Created attachment 333970 [details] Patch
Brent Fulgham
Comment 8 2018-02-16 12:01:36 PST
Comment on attachment 333970 [details] Patch Looks great! r=me.
Jiewen Tan
Comment 9 2018-02-16 12:17:49 PST
(In reply to Brent Fulgham from comment #8) > Comment on attachment 333970 [details] > Patch > > Looks great! r=me. Thanks Brent for r+ the patch.
WebKit Commit Bot
Comment 10 2018-02-16 12:43:32 PST
Comment on attachment 333970 [details] Patch Clearing flags on attachment: 333970 Committed r228572: <https://trac.webkit.org/changeset/228572>
WebKit Commit Bot
Comment 11 2018-02-16 12:43:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.