Bug 181689

Summary: Update web platform tests for Visual Viewport API
Product: WebKit Reporter: Ali Juma <ajuma>
Component: DOMAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ews-watchlist, fred.wang, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170982    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch none

Ali Juma
Reported 2018-01-16 10:25:13 PST
There are two upstream commits to import: 1) The directory for visual viewport WPTs has been renamed from 'viewport' to 'visual-viewport' (https://github.com/w3c/web-platform-tests/commit/f878fee4df619e55c7fbfce1a2ff5e5d4d83a03b). 2) viewport-resize-event-on-load-overflowing-page.html has been updated (https://github.com/w3c/web-platform-tests/commit/03a684d63e62d85cffed38bc942f468692d7d54f).
Attachments
Patch (104.46 KB, patch)
2018-01-16 10:40 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Patch (104.21 KB, patch)
2018-01-16 10:42 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.14 MB, application/zip)
2018-01-16 12:13 PST, EWS Watchlist 		no flags
Details
Patch (104.34 KB, patch)
2018-01-16 12:35 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-01-16 10:40:47 PST
Created attachment 331401 [details] Patch
Ali Juma
Comment 2 2018-01-16 10:42:36 PST
Created attachment 331403 [details] Patch
Alex Christensen
Comment 3 2018-01-16 11:44:58 PST
Comment on attachment 331403 [details] Patch iOS-sim failure looks related: Regressions: Unexpected text-only failures (1) imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html [ Failure ]
EWS Watchlist
Comment 4 2018-01-16 12:13:28 PST
Comment on attachment 331403 [details] Patch Attachment 331403 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6095662 New failing tests: imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html
EWS Watchlist
Comment 5 2018-01-16 12:13:29 PST
Created attachment 331411 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Ali Juma
Comment 6 2018-01-16 12:35:03 PST
Created attachment 331413 [details] Patch
Ali Juma
Comment 7 2018-01-16 12:41:44 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 331403 [details] > Patch > > iOS-sim failure looks related: > > Regressions: Unexpected text-only failures (1) > > imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html > [ Failure ] This failure is pretty hilarious. WebKitTestRunner and DumpRenderTree hardcode that if a test is in a directory called 'viewport' but not 'visual-viewport', we use a flexible viewport (e.g., see https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/TestOptions.cpp#L42). So renaming the directory from viewport to visual-viewport changed the viewport size. The flexible viewport special case is intended for testing viewports in the <meta name="viewport" ...> sense, not visual viewports, so was never supposed to affect these tests to begin with. I've updated the expectation for that test to account for the change in viewport size.
WebKit Commit Bot
Comment 8 2018-01-17 01:34:51 PST
Comment on attachment 331413 [details] Patch Clearing flags on attachment: 331413 Committed r227054: <https://trac.webkit.org/changeset/227054>
WebKit Commit Bot
Comment 9 2018-01-17 01:34:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-01-17 01:35:31 PST
<rdar://problem/36576468>
Note You need to log in before you can comment on or make changes to this bug.