Bug 181548

Summary: window.visualViewport should behave as [SameObject]
Product: WebKit Reporter: Ali Juma <ajuma>
Component: DOMAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170982    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra none

Ali Juma
Reported 2018-01-11 11:21:28 PST
window.visualViewport should behave as [SameObject]. For example: window.visualViewport.myValue = 7; gc(); console.log(window.visualViewport); // Should be 7, not undefined.
Attachments
Patch (3.35 KB, patch)
2018-01-11 11:30 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.51 MB, application/zip)
2018-01-11 13:14 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-01-11 11:30:04 PST
Created attachment 331081 [details] Patch
EWS Watchlist
Comment 2 2018-01-11 13:14:48 PST
Comment on attachment 331081 [details] Patch Attachment 331081 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6038879 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
EWS Watchlist
Comment 3 2018-01-11 13:14:50 PST
Created attachment 331103 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Chris Dumez
Comment 4 2018-01-11 13:19:58 PST
Comment on attachment 331081 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-01-11 13:46:02 PST
Comment on attachment 331081 [details] Patch Clearing flags on attachment: 331081 Committed r226802: <https://trac.webkit.org/changeset/226802>
WebKit Commit Bot
Comment 6 2018-01-11 13:46:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-11 13:48:33 PST
<rdar://problem/36449018>
Note You need to log in before you can comment on or make changes to this bug.