Bug 181220

Summary: Add a WebAuthentication runtime feature flag
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, jiewen_tan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2018-01-02 14:27:44 PST
Add a WebAuthentication runtime feature flag.
Attachments
Patch (23.44 KB, patch)
2018-01-02 14:40 PST, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (23.70 KB, patch)
2018-01-02 15:29 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-01-02 14:28:16 PST
<rdar://problem/36055305>
Jiewen Tan
Comment 2 2018-01-02 14:40:24 PST
Created attachment 330337 [details] Patch
Brent Fulgham
Comment 3 2018-01-02 15:16:00 PST
Comment on attachment 330337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330337&action=review R=me > Source/WebKit/ChangeLog:8 > + Can you paste the same explanation here, and in the other ChangeLogs? “Renaming Credentials... to WebAuthN”
Jiewen Tan
Comment 4 2018-01-02 15:29:52 PST
Created attachment 330345 [details] Patch for landing
Jiewen Tan
Comment 5 2018-01-02 15:38:07 PST
Comment on attachment 330337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330337&action=review Thanks Brent for r+ my patch. >> Source/WebKit/ChangeLog:8 >> + > > Can you paste the same explanation here, and in the other ChangeLogs? “Renaming Credentials... to WebAuthN” Fixed.
WebKit Commit Bot
Comment 6 2018-01-02 16:10:14 PST
Comment on attachment 330345 [details] Patch for landing Clearing flags on attachment: 330345 Committed r226341: <https://trac.webkit.org/changeset/226341>
Note You need to log in before you can comment on or make changes to this bug.