Bug 181117

Summary: [CMake][Win] Visual Studio invokes make_names.pl twice
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: keith_miller
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208771
Attachments:
Description Flags
WIP patch
none
WIP patch
none
WIP patch none

Fujii Hironori
Reported 2017-12-22 00:20:56 PST
[CMake][Win] Visual Studio invokes make_names.pl twice There are build logs of first time clean build and second time incremental build. https://gist.github.com/fujii/e2b46c02cae29e57401df181b69e9494 In the first clean build, for example, HTMLNames.cpp was generated twice in WebCoreDerivedSources and WebCore projects > 22>------ Build started: Project: WebCoreDerivedSources, Configuration: Debug x64 ------ > > 22>Generating ../../DerivedSources/WebCore/HTMLNames.cpp, ../../DerivedSources/WebCore/HTMLNames.h, ../../DerivedSources/WebCore/HTMLElementFactory.cpp, ../../DerivedSources/WebCore/HTMLElementFactory.h, ../../DerivedSources/WebCore/JSHTMLElementWrapperFactory.cpp, ../../DerivedSources/WebCore/JSHTMLElementWrapperFactory.h > > 32>------ Build started: Project: WebCore (WebCore\WebCore), Configuration: Debug x64 ------ > > 32>Generating ../../DerivedSources/WebCore/HTMLNames.cpp, ../../DerivedSources/WebCore/HTMLNames.h, ../../DerivedSources/WebCore/HTMLElementFactory.cpp, ../../DerivedSources/WebCore/HTMLElementFactory.h, ../../DerivedSources/WebCore/JSHTMLElementWrapperFactory.cpp, ../../DerivedSources/WebCore/JSHTMLElementWrapperFactory.h Relevant issues: Bug 177286 – [CMake][Win] EventTargetInterfaces.h are generated twice Bug 163774 – [CMake][Win] Visual Studio invokes make_settings.pl twice
Attachments
WIP patch (1.51 KB, patch)
2018-01-12 00:13 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (5.26 KB, patch)
2018-01-14 22:59 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (7.72 KB, patch)
2018-01-15 01:58 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-12-22 00:23:54 PST
> GENERATE_DOM_NAMES(HTML ${WEBCORE_DIR}/html/HTMLAttributeNames.in ${WEBCORE_DIR}/html/HTMLTagNames.in "") This command generates three files HTMLNames.cpp, HTMLElementFactory.cpp and JSHTMLElementWrapperFactory.cpp. But, only HTMLElementFactory.cpp and JSHTMLElementWrapperFactory.cpp are listed in Sources.txt. Then these files are compiled in WebCore project and HTMLNames.cpp is compiled in WebCoreDerivedSources project. All files should be listed in Sources.txt.
Fujii Hironori
Comment 2 2017-12-22 01:42:42 PST
(In reply to Fujii Hironori from comment #1) > All files should be listed in Sources.txt. After trying this approach, it turned out there is a problems. gperf generated source files aren't able to be unified because of enum collision.
Fujii Hironori
Comment 3 2018-01-12 00:13:44 PST
Created attachment 331178 [details] WIP patch
Fujii Hironori
Comment 4 2018-01-14 22:59:20 PST
Created attachment 331321 [details] WIP patch * The source files in unified source build of WebCore should be listed in WebCore_SOURCES, not in WebCore_DERIVED_SOURCES. * Should not add a source dependency from ${WEBCORE_DIR}/css/CSSPrimitiveValueMappings.h to CSSValueKeywords.h, which causes unnecessary build rule in WebCoreForwardingHeaders project. * Remove source dependency of ${WEBCORE_DIR}/css/CSSParser.cpp because no such file ToT * Should not add WebCoreJSBuiltinInternals.cpp, WebCoreJSBuiltins.cpp and CSSValueKeywords.cpp to WebCore unified source build because they should be built in WebCoreDerivedSources project
Fujii Hironori
Comment 5 2018-01-15 01:58:09 PST
Created attachment 331325 [details] WIP patch
Fujii Hironori
Comment 6 2018-01-15 20:12:28 PST
I'm going to try another approach in Bug 181664.
Fujii Hironori
Comment 7 2018-01-17 00:24:03 PST
I have confirmed this bug has been fixed by Bug 181664. *** This bug has been marked as a duplicate of bug 181664 ***
Note You need to log in before you can comment on or make changes to this bug.