Bug 178887

Summary:

[Payment Request] Restrict API use to secure, same-origin frames

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, keith_miller, sam, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

174796

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-10-26 14:44:21 PDT

[Payment Request] Restrict API use to secure, same-origin frames

Attachments
Patch (19.84 KB, patch) 2017-10-26 14:46 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (20.13 KB, patch) 2017-10-26 15:00 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (20.21 KB, patch) 2017-10-26 15:05 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (21.19 KB, patch) 2017-10-26 15:56 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-10-26 14:46:41 PDT Comment hidden (obsolete)

Created attachment 325058 [details] Patch

Andy Estes

Comment 2 2017-10-26 15:00:17 PDT Comment hidden (obsolete)

Created attachment 325059 [details] Patch

Andy Estes

Comment 3 2017-10-26 15:05:05 PDT Comment hidden (obsolete)

Created attachment 325061 [details] Patch

WebKit Commit Bot

Comment 4 2017-10-26 15:53:40 PDT Comment hidden (obsolete)

Comment on attachment 325061 [details] Patch Rejecting attachment 325061 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 325061, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: yment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5004082

Andy Estes

Comment 5 2017-10-26 15:56:25 PDT

Created attachment 325070 [details] Patch

WebKit Commit Bot

Comment 6 2017-10-26 16:25:14 PDT

The commit-queue encountered the following flaky tests while processing attachment 325070 [details]: media/modern-media-controls/seek-backward-support/seek-backward-support.html bug 174916 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2017-10-26 16:25:45 PDT

Comment on attachment 325070 [details] Patch Clearing flags on attachment: 325070 Committed r224061: <https://trac.webkit.org/changeset/224061>

WebKit Commit Bot

Comment 8 2017-10-26 16:25:46 PDT

All reviewed patches have been landed. Closing bug.

Keith Miller

Comment 9 2017-10-26 16:28:35 PDT

Committed r224062: <https://trac.webkit.org/changeset/224062>

Radar WebKit Bug Importer

Comment 10 2017-11-15 12:41:30 PST

<rdar://problem/35567954>

Note You need to log in before you can comment on or make changes to this bug.