Bug 174426

Summary:

Allow clients to override their own hardware media requirements where no fallback media exists.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch for landing	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan	none
Patch for landing	none

Jer Noble

Reported 2017-07-12 09:57:56 PDT

Allow clients to override their own hardware media requirements where no fallback media exists.

Attachments
Patch (30.99 KB, patch) 2017-07-12 10:12 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (30.54 KB, patch) 2017-07-12 10:31 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.30 MB, application/zip) 2017-07-12 12:36 PDT, Build Bot	no flags	Details
Patch for landing (16.65 KB, patch) 2017-07-12 15:00 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.01 MB, application/zip) 2017-07-12 16:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.21 MB, application/zip) 2017-07-12 16:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.06 MB, application/zip) 2017-07-12 16:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.94 MB, application/zip) 2017-07-12 17:42 PDT, Build Bot	no flags	Details
Patch for landing (32.35 KB, patch) 2017-07-14 10:45 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (32.35 KB, patch) 2017-07-14 11:06 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan (1.20 MB, application/zip) 2017-07-14 11:53 PDT, WebKit Commit Bot	no flags	Details
Patch for landing (32.35 KB, patch) 2017-07-14 13:20 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2017-07-12 09:58:43 PDT

<rdar://problem/32537704>

Jer Noble

Comment 2 2017-07-12 10:12:26 PDT

Created attachment 315253 [details] Patch

Eric Carlson

Comment 3 2017-07-12 10:26:36 PDT

Comment on attachment 315253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315253&action=review r=me once it applies and compiles > Source/WebCore/ChangeLog:9 > + Add a new Setting which allows clients to specify that their own mediaContentTypesRequiringHardwareSupport in Nit: don't need the "that" in "specify that their own". > Source/WebKit/mac/ChangeLog:9 > + Add a new WebPreferences property able to control WebCore's new Nit: don't need "able". > Source/WebKit/mac/ChangeLog:10 > + allowMediaContentTypesRequiringHardwareSupportAsFallback Setting. Nit: "Setting" shouldn't be capitalized. > Source/WebKit2/ChangeLog:10 > + WebCore's new allowMediaContentTypesRequiringHardwareSupportAsFallback Setting. Ditto. > Source/WebCore/html/HTMLMediaElement.h:173 > + void rejectPendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&, DOMError&); > + void resolvePendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&); Did you mean to leave this in this patch?

Jer Noble

Comment 4 2017-07-12 10:30:49 PDT

(In reply to Eric Carlson from comment #3) > Comment on attachment 315253 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315253&action=review > > r=me once it applies and compiles > > > Source/WebCore/ChangeLog:9 > > + Add a new Setting which allows clients to specify that their own mediaContentTypesRequiringHardwareSupport in > > Nit: don't need the "that" in "specify that their own". Fixed. > > Source/WebKit/mac/ChangeLog:9 > > + Add a new WebPreferences property able to control WebCore's new > > Nit: don't need "able". Fixed. > > Source/WebKit/mac/ChangeLog:10 > > + allowMediaContentTypesRequiringHardwareSupportAsFallback Setting. > > Nit: "Setting" shouldn't be capitalized. Fixed. > > Source/WebKit2/ChangeLog:10 > > + WebCore's new allowMediaContentTypesRequiringHardwareSupportAsFallback Setting. > > Ditto. Fixed. > > Source/WebCore/html/HTMLMediaElement.h:173 > > + void rejectPendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&, DOMError&); > > + void resolvePendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&); > > Did you mean to leave this in this patch? Nope! Part of another patch. Fixed.

Jer Noble

Comment 5 2017-07-12 10:31:23 PDT

Created attachment 315258 [details] Patch for landing

Build Bot

Comment 6 2017-07-12 10:36:14 PDT Comment hidden (obsolete)

Attachment 315258 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221: 'nextNode' is incorrectly named. It should be named 'protector' or 'protectedNextChildNodeToConsider'. [readability/naming/protected] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 7 2017-07-12 10:39:41 PDT

(In reply to Build Bot from comment #6) > Attachment 315258 [details] did not pass style-queue: > > > ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221: 'nextNode' is > incorrectly named. It should be named 'protector' or > 'protectedNextChildNodeToConsider'. [readability/naming/protected] [4] > Total errors found: 1 in 21 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Bad Style Bot. No Cookie.

Build Bot

Comment 8 2017-07-12 12:36:27 PDT Comment hidden (obsolete)

Comment on attachment 315258 [details] Patch for landing Attachment 315258 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4108697 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-07-12 12:36:28 PDT Comment hidden (obsolete)

Created attachment 315272 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Jer Noble

Comment 10 2017-07-12 15:00:16 PDT

Created attachment 315285 [details] Patch for landing

Build Bot

Comment 11 2017-07-12 15:03:45 PDT

Attachment 315285 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221: 'nextNode' is incorrectly named. It should be named 'protector' or 'protectedNextChildNodeToConsider'. [readability/naming/protected] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 12 2017-07-12 16:05:37 PDT

Comment on attachment 315285 [details] Patch for landing Attachment 315285 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4109708 New failing tests: media/media-blocked-by-beforeload.html media/video-beforeload-remove-source.html

Build Bot

Comment 13 2017-07-12 16:05:38 PDT

Created attachment 315297 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2017-07-12 16:20:29 PDT

Comment on attachment 315285 [details] Patch for landing Attachment 315285 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4109724 New failing tests: media/media-blocked-by-beforeload.html media/video-beforeload-remove-source.html

Build Bot

Comment 15 2017-07-12 16:20:31 PDT

Created attachment 315300 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2017-07-12 16:48:33 PDT

Comment on attachment 315285 [details] Patch for landing Attachment 315285 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4109815 New failing tests: media/media-blocked-by-beforeload.html media/video-beforeload-remove-source.html

Build Bot

Comment 17 2017-07-12 16:48:34 PDT

Created attachment 315307 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Build Bot

Comment 18 2017-07-12 17:42:43 PDT

Comment on attachment 315285 [details] Patch for landing Attachment 315285 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4110161 New failing tests: media/video-source-removed.html media/media-blocked-by-beforeload.html media/video-beforeload-remove-source.html

Build Bot

Comment 19 2017-07-12 17:42:45 PDT

Created attachment 315319 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jer Noble

Comment 20 2017-07-14 10:45:49 PDT

Created attachment 315444 [details] Patch for landing

Jer Noble

Comment 21 2017-07-14 11:06:06 PDT

Created attachment 315453 [details] Patch for landing

WebKit Commit Bot

Comment 22 2017-07-14 11:53:43 PDT

Comment on attachment 315453 [details] Patch for landing Rejecting attachment 315453 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.webkit.org/results/4120572

WebKit Commit Bot

Comment 23 2017-07-14 11:53:44 PDT

Created attachment 315468 [details] Archive of layout-test-results from webkit-cq-03 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jer Noble

Comment 24 2017-07-14 13:20:45 PDT

Created attachment 315479 [details] Patch for landing

WebKit Commit Bot

Comment 25 2017-07-14 13:48:13 PDT

The commit-queue encountered the following flaky tests while processing attachment 315479 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 26 2017-07-14 13:48:35 PDT

The commit-queue encountered the following flaky tests while processing attachment 315479 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: beidson@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 27 2017-07-14 15:04:24 PDT

Comment on attachment 315479 [details] Patch for landing Clearing flags on attachment: 315479 Committed r219526: <http://trac.webkit.org/changeset/219526>

WebKit Commit Bot

Comment 28 2017-07-14 15:04:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.