Bug 171994

Summary: [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, commit-queue, ggaren, mdaum
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172030
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2017-05-11 15:07:54 PDT
[WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path <rdar://problem/30612463>
Attachments
Patch (14.96 KB, patch)
2017-05-11 15:13 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (15.02 KB, patch)
2017-05-11 16:26 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (15.16 KB, patch)
2017-05-11 16:44 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-05-11 15:13:34 PDT
Created attachment 309794 [details] Patch
Maureen Daum
Comment 2 2017-05-11 15:57:27 PDT
Comment on attachment 309794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309794&action=review > Source/WebKit2/UIProcess/WebProcessPool.cpp:526 > + m_databaseProcess->send(Messages::DatabaseProcess::InitializeWebsiteDataStore(parameters), 0); If there is a relevantDataStore that'll cause us to send the InitializeWebsiteDataStore event below, do we need to send it here as well?
Brady Eidson
Comment 3 2017-05-11 16:17:54 PDT
(In reply to Maureen Daum from comment #2) > Comment on attachment 309794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309794&action=review > > > Source/WebKit2/UIProcess/WebProcessPool.cpp:526 > > + m_databaseProcess->send(Messages::DatabaseProcess::InitializeWebsiteDataStore(parameters), 0); > > If there is a relevantDataStore that'll cause us to send the > InitializeWebsiteDataStore event below, do we need to send it here as well? Good call - Easy to fall in the trap of sending it twice. Wouldn't be a big deal, but definitely don't need to do it.
Brady Eidson
Comment 4 2017-05-11 16:26:41 PDT
Created attachment 309815 [details] Patch
Andy Estes
Comment 5 2017-05-11 16:40:17 PDT
Comment on attachment 309815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309815&action=review > Source/WebKit2/UIProcess/WebProcessPool.cpp:532 > + auto parameters = relevantDataStore->databaseProcessParameters(); Unnecessary local variable.
Brady Eidson
Comment 6 2017-05-11 16:44:34 PDT
Created attachment 309822 [details] Patch
WebKit Commit Bot
Comment 7 2017-05-11 17:49:36 PDT
Comment on attachment 309822 [details] Patch Clearing flags on attachment: 309822 Committed r216711: <http://trac.webkit.org/changeset/216711>
WebKit Commit Bot
Comment 8 2017-05-11 17:49:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.