Bug 162167

Summary: Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, cgarcia, gyuyoung.kim, koivisto, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2 none

Daniel Bates
Reported 2016-09-19 10:42:42 PDT
Currently WebKit contains two implementations for automatic text-size adjustment guarded by ENABLE(TEXT_AUTOSIZING) and ENABLE(IOS_TEXT_AUTOSIZING). As far as I can tell TEXT_AUTOSIZING is not enabled on any port and its code is likely stale given that it is not enabled on any port. On Mac and iOS, WebKit is built with IOS_TEXT_AUTOSIZING enabled. We should remove all the ENABLE(TEXT_AUTOSIZING) code as it is unused. For completeness, ENABLE(TEXT_AUTOSIZING) was added as part of the work for bug #84186. There has also been an effort to standardize the IOS_TEXT_AUTOSIZING behavior as part of the CSS Mobile Text Size Adjustment Module Level 1 spec., <https://drafts.csswg.org/css-size-adjust/>.
Attachments
Patch (310.70 KB, patch)
2016-09-19 10:54 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (306.23 KB, patch)
2016-09-19 12:58 PDT, Daniel Bates 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2 (8.12 MB, application/zip)
2016-09-19 14:26 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-09-19 10:54:51 PDT
Created attachment 289240 [details] Patch
Daniel Bates
Comment 2 2016-09-19 11:01:05 PDT
Assuming it is acceptable to remove the ENABLE(TEXT_AUTOSIZING) code. Then I will close bug #84186 and all its child bugs as Resolved Invalid (is a more appropriate status to use?).
Michael Catanzaro
Comment 3 2016-09-19 11:32:29 PDT
I would use Resolved Wontfix, but it doesn't matter much.
Daniel Bates
Comment 4 2016-09-19 12:58:55 PDT
Created attachment 289248 [details] Patch Revert inadvertent removal of files TextAutosizing.{cpp, h} from the WebCore Xcode project. These files are used by the iOS automatic text size adjustment code.
Build Bot
Comment 5 2016-09-19 14:26:47 PDT
Comment on attachment 289248 [details] Patch Attachment 289248 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2107456 New failing tests: fast/text-autosizing/ios/line-height-text-autosizing.html
Build Bot
Comment 6 2016-09-19 14:26:50 PDT
Created attachment 289254 [details] Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6
Daniel Bates
Comment 7 2016-09-19 14:27:36 PDT
Committed r206119: <http://trac.webkit.org/changeset/206119>
Daniel Bates
Comment 8 2016-09-19 14:31:48 PDT
(In reply to comment #5) > Comment on attachment 289248 [details] > Patch > > Attachment 289248 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/2107456 > > New failing tests: > fast/text-autosizing/ios/line-height-text-autosizing.html I updated LayoutTests/platform/ios-simulator/TestExpectations to mark this test as Failure before landing the patch for this bug. This test began failing with attachment #289248 [details] because I removed the Failure entry for fast/text-autosizing/ios/line-height-text-autosizing.html from the WK1/WK2 TestExpectations. I filed bug #162236 to investigate the failure of this test on iOS.
Note You need to log in before you can comment on or make changes to this bug.