Bug 159715

Summary:

Import more tests from the MathML in HTML5 test suite

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, dbarton, rego, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

139403, 157989, 158866

Bug Blocks:

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Patch	none

Frédéric Wang (:fredw)

Reported 2016-07-13 08:31:54 PDT

Many of the tests from the MathML in HTML5 suite pass in WebKit, so we can import them. Removing old and unexplained CSS rules from the MathML user agent stylesheet will help here (bug 157989 and bug 139403).

Attachments
Patch (65.62 KB, patch) 2016-07-14 05:39 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (833.21 KB, application/zip) 2016-07-14 06:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (777.19 KB, application/zip) 2016-07-14 06:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.47 MB, application/zip) 2016-07-14 06:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (645.30 KB, application/zip) 2016-07-14 06:50 PDT, Build Bot	no flags	Details
Patch (65.62 KB, patch) 2016-07-15 00:29 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.04 MB, application/zip) 2016-07-15 01:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (964.80 KB, application/zip) 2016-07-15 01:03 PDT, Build Bot	no flags	Details
Patch (67.55 KB, patch) 2016-07-15 01:05 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2016-07-14 05:39:01 PDT

Created attachment 283633 [details] Patch

Build Bot

Comment 2 2016-07-14 06:26:35 PDT

Comment on attachment 283633 [details] Patch Attachment 283633 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1680018 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html imported/mathml-in-html5/mathml/relations/css-styling/color-1.html

Build Bot

Comment 3 2016-07-14 06:26:38 PDT

Created attachment 283635 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-07-14 06:28:43 PDT

Comment on attachment 283633 [details] Patch Attachment 283633 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1680023 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html imported/mathml-in-html5/mathml/relations/css-styling/color-1.html

Build Bot

Comment 5 2016-07-14 06:28:46 PDT

Created attachment 283636 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-07-14 06:39:33 PDT

Comment on attachment 283633 [details] Patch Attachment 283633 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1680032 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html imported/mathml-in-html5/mathml/relations/css-styling/color-1.html

Build Bot

Comment 7 2016-07-14 06:39:36 PDT

Created attachment 283638 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-07-14 06:50:12 PDT

Comment on attachment 283633 [details] Patch Attachment 283633 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1680051 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html

Build Bot

Comment 9 2016-07-14 06:50:15 PDT

Created attachment 283639 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Frédéric Wang (:fredw)

Comment 10 2016-07-14 11:44:05 PDT

The failure of the typo test on mac / ios is expected as the USE_TYPO_METRICS is ignored for non-math fonts on these platforms (bug 150394 comment 12). The other failure just seems a 1-pixel diff due to antialiasing. I'll try uploading a new patch tomorrow.

Frédéric Wang (:fredw)

Comment 11 2016-07-15 00:29:36 PDT

Created attachment 283744 [details] Patch

Build Bot

Comment 12 2016-07-15 01:01:53 PDT

Comment on attachment 283744 [details] Patch Attachment 283744 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1684395 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html imported/mathml-in-html5/mathml/relations/css-styling/color-1.html

Build Bot

Comment 13 2016-07-15 01:01:57 PDT

Created attachment 283745 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 14 2016-07-15 01:03:23 PDT

Comment on attachment 283744 [details] Patch Attachment 283744 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1684405 New failing tests: imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html imported/mathml-in-html5/mathml/relations/css-styling/color-1.html

Build Bot

Comment 15 2016-07-15 01:03:26 PDT

Created attachment 283746 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Frédéric Wang (:fredw)

Comment 16 2016-07-15 01:05:17 PDT

Created attachment 283747 [details] Patch Oops, I uploaded the wrong patch. Here is the correct one.

Brent Fulgham

Comment 17 2016-07-15 09:27:20 PDT

Comment on attachment 283747 [details] Patch Yay! More tests! :-) r=me.

WebKit Commit Bot

Comment 18 2016-07-15 09:49:07 PDT

Comment on attachment 283747 [details] Patch Clearing flags on attachment: 283747 Committed r203278: <http://trac.webkit.org/changeset/203278>

WebKit Commit Bot

Comment 19 2016-07-15 09:49:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.