Bug 157473

Summary: [css-grid] Implement auto-repeat computation
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, ggaren, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Sergio Villar Senin
Reported 2016-05-09 05:34:10 PDT
[css-grid] Implement auto-repeat computation
Attachments
Patch (152.49 KB, patch)
2016-05-09 05:51 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2016-05-09 05:51:34 PDT
Created attachment 278403 [details] Patch
Darin Adler
Comment 2 2016-05-09 12:21:44 PDT
Comment on attachment 278403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278403&action=review > Source/WebCore/css/CSSParser.cpp:6013 > + list.append(*repeatedValues.get()); Should not need .get() here. > Source/WebCore/css/CSSParser.cpp:6015 > + for (size_t i = 0; i < repetitions; ++i) { Since repetitions is an unsigned it seems peculiar to use size_t as the type for the loop. > Source/WebCore/rendering/RenderGrid.cpp:725 > + if (LIKELY(!repetitions) || untranslatedIndex < insertionPoint) Seems excessive to use LIKELY here. Normally we only use those when we have solid evidence they will boost performance.
Sergio Villar Senin
Comment 3 2016-05-10 00:45:31 PDT
Committed r200618: <http://trac.webkit.org/changeset/200618>
Note You need to log in before you can comment on or make changes to this bug.