Bug 156682

Summary:

[Fetch] Use @isArray instead of `instanceof @Array`

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Yusuke Suzuki

Reported 2016-04-17 15:10:19 PDT

[Fetch] Use @isArray instead of `instanceof @Array`

Attachments
Patch (3.19 KB, patch) 2016-04-17 15:13 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (3.90 KB, patch) 2016-04-17 15:15 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (775.93 KB, application/zip) 2016-04-17 15:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (801.48 KB, application/zip) 2016-04-17 16:03 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (621.78 KB, application/zip) 2016-04-17 16:08 PDT, Build Bot	no flags	Details
Patch (3.90 KB, patch) 2016-04-17 16:58 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2016-04-17 15:13:15 PDT

Created attachment 276599 [details] Patch Should add expect file

Yusuke Suzuki

Comment 2 2016-04-17 15:15:48 PDT

Created attachment 276600 [details] Patch

Build Bot

Comment 3 2016-04-17 15:59:36 PDT

Comment on attachment 276600 [details] Patch Attachment 276600 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1177406 New failing tests: fetch/header-constructor-is-array.html

Build Bot

Comment 4 2016-04-17 15:59:39 PDT

Created attachment 276603 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-04-17 16:03:06 PDT

Comment on attachment 276600 [details] Patch Attachment 276600 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1177427 New failing tests: fetch/header-constructor-is-array.html

Build Bot

Comment 6 2016-04-17 16:03:09 PDT

Created attachment 276604 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-04-17 16:08:13 PDT

Comment on attachment 276600 [details] Patch Attachment 276600 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1177432 New failing tests: fetch/header-constructor-is-array.html

Build Bot

Comment 8 2016-04-17 16:08:15 PDT

Created attachment 276605 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5

Yusuke Suzuki

Comment 9 2016-04-17 16:58:32 PDT

Created attachment 276612 [details] Patch

WebKit Commit Bot

Comment 10 2016-04-18 01:00:53 PDT

Comment on attachment 276612 [details] Patch Clearing flags on attachment: 276612 Committed r199654: <http://trac.webkit.org/changeset/199654>

WebKit Commit Bot

Comment 11 2016-04-18 01:00:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.