Bug 153732

Summary:

Cut down on calls to String::lower; mostly replace with convertToASCIILowercase

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	dino: review+

Darin Adler

Reported 2016-01-31 17:02:35 PST

Cut down on calls to String::lower; mostly replace with convertToASCIILowercase

Attachments
Patch (116.42 KB, patch) 2016-01-31 18:32 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (116.58 KB, patch) 2016-01-31 18:35 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (769.70 KB, application/zip) 2016-01-31 19:39 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (965.73 KB, application/zip) 2016-01-31 19:43 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (833.50 KB, application/zip) 2016-01-31 19:47 PST, Build Bot	no flags	Details
Patch (121.80 KB, patch) 2016-01-31 20:11 PST, Darin Adler	dino: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2016-01-31 18:32:29 PST

Created attachment 270359 [details] Patch

Darin Adler

Comment 2 2016-01-31 18:33:55 PST

This first batch covers things I ran into going alphabetically through the source code. I stopped before the "html" directory, and there are a lot of call sites for String::lower in there and beyond.

WebKit Commit Bot

Comment 3 2016-01-31 18:34:21 PST

Attachment 270359 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:887: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1513: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1116: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:85: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1371: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 7 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 4 2016-01-31 18:35:29 PST

Created attachment 270360 [details] Patch

WebKit Commit Bot

Comment 5 2016-01-31 18:37:06 PST

Attachment 270360 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:887: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1513: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1116: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:85: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1371: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 7 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2016-01-31 19:39:34 PST

Comment on attachment 270360 [details] Patch Attachment 270360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/765998 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/search_input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/required_attribute.html fast/canvas/webgl/antialiasing-enabled.html animations/restart-after-scroll.html animations/restart-after-scroll-nested.html animations/dynamic-stylesheet-loading.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/pattern_attribute.html

Build Bot

Comment 7 2016-01-31 19:39:37 PST

Created attachment 270362 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-01-31 19:43:17 PST

Comment on attachment 270360 [details] Patch Attachment 270360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/766001 New failing tests: animations/dynamic-stylesheet-loading.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/pattern_attribute.html fast/canvas/webgl/antialiasing-enabled.html animations/restart-after-scroll.html animations/restart-after-scroll-nested.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/search_input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/required_attribute.html

Build Bot

Comment 9 2016-01-31 19:43:20 PST

Created attachment 270364 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-01-31 19:47:08 PST

Comment on attachment 270360 [details] Patch Attachment 270360 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/766005 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/search_input.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range.html fast/canvas/webgl/antialiasing-enabled.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/pattern_attribute.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime.html animations/restart-after-scroll-nested.html animations/dynamic-stylesheet-loading.html imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/required_attribute.html

Build Bot

Comment 11 2016-01-31 19:47:11 PST

Created attachment 270365 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Darin Adler

Comment 12 2016-01-31 20:11:28 PST

Created attachment 270366 [details] Patch

WebKit Commit Bot

Comment 13 2016-01-31 20:14:20 PST

Attachment 270366 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:887: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1513: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1116: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:85: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1666: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1371: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 14 2016-01-31 20:15:42 PST

Style checker doesn’t seem to understand the style we use for lambdas. I am supposed to file a bug against check-webkit-style about that?

Darin Adler

Comment 15 2016-01-31 20:34:38 PST

OK, let me say that again. The style checker failures are all due to bug 137309.

Darin Adler

Comment 16 2016-01-31 20:36:20 PST

Which is a duplicate of bug 125616.

Darin Adler

Comment 17 2016-01-31 20:40:22 PST

OK, looks like EWS is passing now so it’s time for me to find a reviewer.

Darin Adler

Comment 18 2016-01-31 21:08:16 PST

Comment on attachment 270366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270366&action=review > Source/WebCore/css/CSSParserValues.h:37 > +// 1. The convertToASCIILowercaseInPlace clobbers the data we point to. Probably should have used the word "function" here.

Dean Jackson

Comment 19 2016-01-31 21:37:20 PST

Comment on attachment 270366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270366&action=review > Source/WebCore/css/CSSParser.cpp:1202 > + // Don't try to parse initial/inherit/unset/revert shorthands; return an error so it the caller will use the full CSS parser. return an error so the caller... (remove "it") > Source/WebCore/css/CSSParserValues.h:39 > +// But it sure would be nice if it was a StringView. I feel like this sentence needs to end with "!"

Darin Adler

Comment 20 2016-01-31 21:46:25 PST

Committed r195951: <http://trac.webkit.org/changeset/195951>

Note You need to log in before you can comment on or make changes to this bug.