Bug 151956

Summary: Update options for benchmark
Product: WebKit Reporter: Jon Lee <jonlee>
Component: AnimationsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing none

Jon Lee
Reported 2015-12-07 12:37:29 PST
Merge some of the checkbox-based options into radio groups, and add a way to remove the border display
Attachments
Patch (16.70 KB, patch)
2015-12-07 12:59 PST, Jon Lee 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for landing (16.79 KB, patch)
2015-12-07 13:28 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-12-07 12:41:21 PST
<rdar://problem/23788273>
Jon Lee
Comment 2 2015-12-07 12:59:47 PST
Created attachment 266799 [details] Patch
Simon Fraser (smfr)
Comment 3 2015-12-07 13:03:45 PST
Comment on attachment 266799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266799&action=review > PerformanceTests/Animometer/runner/resources/animometer.js:146 > + var formElement = document.forms[0].elements[name]; Should we give the form a name rather than using forms[0]? > PerformanceTests/Animometer/runner/resources/animometer.js:154 > + var formElements = document.forms[0].elements; Ditto. > PerformanceTests/Animometer/runner/resources/animometer.js:176 > + var formElements = document.forms[0].elements; Ditto.
Jon Lee
Comment 4 2015-12-07 13:24:33 PST
(In reply to comment #3) > Comment on attachment 266799 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266799&action=review > > > PerformanceTests/Animometer/runner/resources/animometer.js:146 > > + var formElement = document.forms[0].elements[name]; > > Should we give the form a name rather than using forms[0]? > > > PerformanceTests/Animometer/runner/resources/animometer.js:154 > > + var formElements = document.forms[0].elements; > > Ditto. > > > PerformanceTests/Animometer/runner/resources/animometer.js:176 > > + var formElements = document.forms[0].elements; > > Ditto. I changed it to use a name instead. Thanks!
Jon Lee
Comment 5 2015-12-07 13:28:04 PST
Created attachment 266802 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-12-07 14:14:45 PST
Comment on attachment 266802 [details] Patch for landing Clearing flags on attachment: 266802 Committed r193650: <http://trac.webkit.org/changeset/193650>
WebKit Commit Bot
Comment 7 2015-12-07 14:14:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.