Bug 150162

Summary: Implement iterator for traversing composed ancestors
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, kondapallykalyan, rniwa, WebkitBugTracker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks
none
patch none

Antti Koivisto
Reported 2015-10-15 05:24:32 PDT
The existing general purpose iterator can traverse parent chain but not efficiently (since it builds stack). Add a separate stackless iterator for ancestor chain traversal.
Attachments
patch (28.41 KB, patch)
2015-10-15 05:42 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (895.72 KB, application/zip)
2015-10-15 06:26 PDT, Build Bot 		no flags
Details
patch (28.49 KB, patch)
2015-10-15 06:27 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-10-15 05:42:33 PDT
Created attachment 263145 [details] patch
Build Bot
Comment 2 2015-10-15 06:26:28 PDT
Comment on attachment 263145 [details] patch Attachment 263145 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/290839 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2015-10-15 06:26:32 PDT
Created attachment 263149 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Antti Koivisto
Comment 4 2015-10-15 06:27:10 PDT
Created attachment 263150 [details] patch
Andreas Kling
Comment 5 2015-10-15 07:16:56 PDT
Comment on attachment 263150 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=263150&action=review r=me > Source/WebCore/dom/Node.h:618 > + // HeyItIsAFreeBit = 1 << 22, Nice.
WebKit Commit Bot
Comment 6 2015-10-15 08:13:16 PDT
Comment on attachment 263150 [details] patch Clearing flags on attachment: 263150 Committed r191112: <http://trac.webkit.org/changeset/191112>
WebKit Commit Bot
Comment 7 2015-10-15 08:13:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.