Bug 149592

<rdar://problem/22875826>

Created attachment 270287 [details] Fixes the bug

Created attachment 270289 [details] Patch for landing

Comment on attachment 270289 [details] Patch for landing Wait for EWS.

Comment on attachment 270289 [details] Patch for landing Attachment 270289 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/758024 New failing tests: fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html fast/dom/Geolocation/stopUpdatingForHiddenPage.html

Created attachment 270296 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 270296 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 I don't think this test failure is related to the change.

Comment on attachment 270289 [details] Patch for landing Clearing flags on attachment: 270289 Committed r195899: <http://trac.webkit.org/changeset/195899>

All reviewed patches have been landed. Closing bug.

It somehow broke the GTK build on the debug bot (but not the release bot): In file included from ../../Source/WebCore/dom/Node.h:38:0, from ../../Source/WebCore/dom/EventContext.h:31, from ../../Source/WebCore/dom/EventDispatcher.cpp:29: ../../Source/WTF/wtf/TypeCasts.h: In instantiation of ‘static bool WTF::TypeCastTraits<ExpectedType, ArgType, isBaseType>::isOfType(ArgType&) [with ExpectedType = const WebCore::TouchEventContext; ArgType = const WebCore::EventContext; bool isBaseType = false]’: ../../Source/WTF/wtf/TypeCasts.h:59:78: required from ‘bool WTF::is(ArgType&) [with ExpectedType = WebCore::TouchEventContext; ArgType = WebCore::EventContext]’ ../../Source/WTF/wtf/TypeCasts.h:80:25: required from ‘typename WTF::match_constness<Source, Target>::type& WTF::downcast(Source&) [with Target = WebCore::TouchEventContext; Source = WebCore::EventContext; typename WTF::match_constness<Source, Target>::type = WebCore::TouchEventContext]’ ../../Source/WebCore/dom/EventDispatcher.cpp:560:45: required from here ../../Source/WTF/wtf/TypeCasts.h:42:9: error: static assertion failed: Missing TypeCastTraits specialization static_assert(std::is_void<ExpectedType>::value, "Missing TypeCastTraits specialization"); ^ ninja: build stopped: subcommand failed.

Fix landed as http://trac.webkit.org/changeset/195919

We need to skip the test LayoutTests/fast/shadow-dom/touch-event-ios.html on the OpenSource iOS bots because touch events are not supported when WebKit is built with the public iOS SDK (we need to fix bug #141906). On another note, I am saddened that this test was not written to run in DumpRenderTree. Notice that the EventSender object has various functions to test touch events, including {add, update, release}TouchPoint(). Examples of using this functionality can be seen in the iOS tests in LayoutTests/platform/ios-simulator/ios.

(In reply to comment #12) > We need to skip the test LayoutTests/fast/shadow-dom/touch-event-ios.html on > the OpenSource iOS bots because touch events are not supported when WebKit > is built with the public iOS SDK (we need to fix bug #141906). > > On another note, I am saddened that this test was not written to run in > DumpRenderTree. Notice that the EventSender object has various functions to > test touch events, including {add, update, release}TouchPoint(). Examples of > using this functionality can be seen in the iOS tests in > LayoutTests/platform/ios-simulator/ios. But those event sender features aren't supported by WKTR, are they?

(In reply to comment #13) > > [...] > > On another note, I am saddened that this test was not written to run in > > DumpRenderTree. Notice that the EventSender object has various functions to > > test touch events, including {add, update, release}TouchPoint(). Examples of > > using this functionality can be seen in the iOS tests in > > LayoutTests/platform/ios-simulator/ios. > > But those event sender features aren't supported by WKTR, are they? No, such features are not implemented in EventSender used in WTR. You can use feature testing to make use of UIController or EventSender as appropriate. One example of such a test is <http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html?rev=194038>. This test uses EventSender to simulate mouse events. A similiar approach can be used to have EventSender simulate touch events.

We're hitting now hitting an assert on the GTK+ debug bot, see bug #153741.

Skipped fast/shadow-dom/touch-event-ios.html on ios-simulator in <https://trac.webkit.org/r195976>