Bug 148792

Summary: [ARM] Fix the ARM Traditional build after r189288
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, zherczeg
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 148742    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-09-04 02:22:53 PDT
https://trac.webkit.org/changeset/189288 broke the ARM Traditional build. https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/14916 build log: ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.h: In function 'void JSC::ctiPatchCallByReturnAddress(JSC::ReturnAddressPtr, JSC::FunctionPtr)': ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1489:17: error: 'static void JSC::MacroAssemblerARM::repatchCall(JSC::CodeLocationCall, JSC::FunctionPtr)' is private ... I'm going to try to fix it in few days.
Attachments
Patch (2.21 KB, patch)
2015-09-04 03:25 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-09-04 03:25:55 PDT
Created attachment 260581 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-04 04:16:10 PDT
Comment on attachment 260581 [details] Patch Clearing flags on attachment: 260581 Committed r189342: <http://trac.webkit.org/changeset/189342>
WebKit Commit Bot
Comment 3 2015-09-04 04:16:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.