Bug 148742

Summary: Get rid of RepatchBuffer and replace it with static functions
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on: 148741, 148792    
Bug Blocks: 148743    
Attachments:
Description Flags
it's a start
none
getting close
none
the patch ggaren: review+

Filip Pizlo
Reported 2015-09-03 11:15:56 PDT
Once RepatchBuffer is stateless, it won't make any sense to instantiate it or pass it around.
Attachments
it's a start (49.35 KB, patch)
2015-09-03 13:26 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
getting close (81.94 KB, patch)
2015-09-03 13:47 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (87.66 KB, patch)
2015-09-03 13:57 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-09-03 13:26:48 PDT
Created attachment 260516 [details] it's a start
Filip Pizlo
Comment 2 2015-09-03 13:47:36 PDT
Created attachment 260518 [details] getting close
Filip Pizlo
Comment 3 2015-09-03 13:57:57 PDT
Created attachment 260519 [details] the patch
Geoffrey Garen
Comment 4 2015-09-03 13:59:07 PDT
Comment on attachment 260519 [details] the patch r=me
WebKit Commit Bot
Comment 5 2015-09-03 14:01:10 PDT
Attachment 260519 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JIT.h:183: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 6 2015-09-03 14:05:19 PDT
Comment on attachment 260519 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=260519&action=review r=me > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003 > - <ClInclude Include="..\assembler\RepatchBuffer.h"> > - <Filter>assembler</Filter> > - </ClInclude> You also need to remove this from Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj
Filip Pizlo
Comment 7 2015-09-03 14:12:09 PDT
(In reply to comment #6) > Comment on attachment 260519 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260519&action=review > > r=me > > > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003 > > - <ClInclude Include="..\assembler\RepatchBuffer.h"> > > - <Filter>assembler</Filter> > > - </ClInclude> > > You also need to remove this from > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj Fixed, along with 32-bit builds.
Filip Pizlo
Comment 8 2015-09-03 14:12:30 PDT
Landed in http://trac.webkit.org/changeset/189288
Note You need to log in before you can comment on or make changes to this bug.