Bug 142686

Summary:

Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

141174

Attachments:

Description	Flags
the patch	oliver: review+

Filip Pizlo

Reported 2015-03-13 18:37:42 PDT

When you run the elidable-new-object-roflcopter test, you'll see that there are many repeated PutStructureHints and PutByOffsetHints. These are because we handle already-sunken allocations from previous fixpoint iterations inside the code for handling those allocations we are sinking on *this* fixpoint iteration. This is a mostly benign bug; its main effect is that if the phase does many fixpoint iterations then you'll get a lot of duplicated code.

Attachments
the patch (3.19 KB, patch) 2015-03-13 18:39 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2015-03-13 18:39:21 PDT

Created attachment 248631 [details] the patch

Filip Pizlo

Comment 2 2015-03-13 19:51:36 PDT

Landed in http://trac.webkit.org/changeset/181495

Note You need to log in before you can comment on or make changes to this bug.