Bug 142659

Summary: Web Inspector: Inline errors on neighboring lines may collide if expandable
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: graouts, inspector-bugzilla-changes, jonowells, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Issue - Overlapping Errors/Warnings none

Joseph Pecoraro
Reported 2015-03-13 00:13:32 PDT
* SUMMARY Inline errors on neighboring lines may collide if expandable. * TEST <script> console.error("really really long error message that will need to be expanded"); console.warn("warning will collide"); </script> * STEPS TO REPRODUCE 1. Inspect test case. 2. Jump to error 3. Click to expand truncated error message => overlap between the expanded error hanging under line 1 and the warning on line 2
Attachments
[IMAGE] Issue - Overlapping Errors/Warnings (63.85 KB, image/png)
2015-03-13 00:18 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-13 00:13:53 PDT
<rdar://problem/20149912>
Joseph Pecoraro
Comment 2 2015-03-13 00:17:16 PDT
I knew about this issue, but I don't consider it that important to fix yet. I don't think it is a common case to have errors on adjacent lines. I also don't think it will be common to need to expand errors (truncation, or multiple errors on a line). I think until this is actually seen in real content, or if it becomes an issue with more frequent inline warnings (lint messages) it is low priority. I don't know what the ideal behavior would be here anyways. - We could just switch to a pop-over, but I don't think that is as nice. - We could check for overlaps and also expand the other inline error/warning, etc.
Joseph Pecoraro
Comment 3 2015-03-13 00:18:16 PDT
Created attachment 248574 [details] [IMAGE] Issue - Overlapping Errors/Warnings
Note You need to log in before you can comment on or make changes to this bug.