Bug 140034

Summary: Kill the DeprecatedStyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910, 140010    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-01-01 16:32:20 PST
Kill the DeprecatedStyleBuilder by moving the remaining CSS properties to the new StyleBuilder (finally!).
Attachments
Patch (70.59 KB, patch)
2015-01-01 19:35 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-01 19:35:25 PST
Created attachment 243880 [details] Patch
Darin Adler
Comment 2 2015-01-02 13:59:36 PST
Comment on attachment 243880 [details] Patch It seems like we are a little overboard on the generated code now. I wish more of the loops and such could db in shared code rather than all in the generated files. But I suppose the only way to do that would be templates, and that was madness before.
WebKit Commit Bot
Comment 3 2015-01-02 14:40:17 PST
Comment on attachment 243880 [details] Patch Clearing flags on attachment: 243880 Committed r177869: <http://trac.webkit.org/changeset/177869>
WebKit Commit Bot
Comment 4 2015-01-02 14:40:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.