Bug 135420

Summary:

[CSS Font Loading] Test expectations should show success

Product:

WebKit

Reporter:

Bear Travis <betravis>

Component:

CSS

Assignee:

Bear Travis <betravis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

135390

Attachments:

Description	Flags
Patch	bjonesbe: review+, bjonesbe: commit-queue-
Updated patch	commit-queue: commit-queue-
Updated patch (with reviewer)	none

Bear Travis

Reported 2014-07-30 10:49:11 PDT

The CSS Font Loading tests currently have failure results in their expectations so that the tests pass. This patch will modify the test expectations to show success, but skip the tests on platforms where the feature is not enabled.

Attachments
Patch (7.13 KB, patch) 2014-07-30 11:17 PDT, Bear Travis	bjonesbe: review+ bjonesbe: commit-queue-	Details Formatted Diff Diff
Updated patch (7.56 KB, patch) 2014-07-30 14:57 PDT, Bear Travis	commit-queue: commit-queue-	Details Formatted Diff Diff
Updated patch (with reviewer) (7.56 KB, patch) 2014-07-30 15:04 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Bear Travis

Comment 1 2014-07-30 11:17:40 PDT

Created attachment 235753 [details] Patch

Bem Jones-Bey

Comment 2 2014-07-30 14:03:10 PDT

Comment on attachment 235753 [details] Patch r=me Please add an update to LayoutTests/http/tests/webfont/fontloader-loading-attribute.html as well before landing.

Bear Travis

Comment 3 2014-07-30 14:57:34 PDT

Created attachment 235767 [details] Updated patch Updating the http/tests/webfont /fontloader test as well.

WebKit Commit Bot

Comment 4 2014-07-30 15:01:03 PDT

Comment on attachment 235767 [details] Updated patch Rejecting attachment 235767 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 235767, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6607813803507712

Bear Travis

Comment 5 2014-07-30 15:04:03 PDT

Created attachment 235770 [details] Updated patch (with reviewer)

WebKit Commit Bot

Comment 6 2014-07-31 10:24:57 PDT

Comment on attachment 235770 [details] Updated patch (with reviewer) Clearing flags on attachment: 235770 Committed r171865: <http://trac.webkit.org/changeset/171865>

WebKit Commit Bot

Comment 7 2014-07-31 10:24:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.