Bug 130453

Summary: [ARM64] GNU assembler doesn't work with LLInt arm64 backend.
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, msaboff, ossy, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 108645, 130506    
Attachments:
Description Flags
proposed fix none

Gabor Rapcsanyi
Reported 2014-03-19 07:38:36 PDT
/tmp/ccqAa03b.s:579: Error: operand 1 should be a floating-point register -- `stp fp,lr,[sp,#-16]!' /tmp/ccqAa03b.s:723: Error: operand 1 should be a floating-point register -- `ldp fp,lr,[sp],#16' /tmp/ccqAa03b.s:734: Error: operand mismatch -- `sxtw x2,x2' /tmp/ccqAa03b.s:1726: Error: operand mismatch -- `uxtw x23,x23'
Attachments
proposed fix (2.33 KB, patch)
2014-03-19 07:42 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2014-03-19 07:42:38 PDT
Created attachment 227181 [details] proposed fix
Zoltan Herczeg
Comment 2 2014-03-24 01:26:18 PDT
Makes sense. If noone has any objection, I will give an r+.
WebKit Commit Bot
Comment 3 2014-03-24 08:24:29 PDT
Comment on attachment 227181 [details] proposed fix Clearing flags on attachment: 227181 Committed r166166: <http://trac.webkit.org/changeset/166166>
WebKit Commit Bot
Comment 4 2014-03-24 08:24:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.