Bug 127868

Summary:

IDB: Index reading

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, jsbell, liachen, mitz, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

124521

Attachments:

Description	Flags
Index writing patch, v1	none
Writing v2 - Fix style nit.	andersca: review+, andersca: commit-queue-
Reading patch v1 - Implement with a cursor!	jer.noble: review+

Jon Lee

Reported 2014-01-29 16:29:53 PST

IDB: Index reading/writing <rdar://problem/15899973>

Attachments
*Index writing* patch, v1** (20.59 KB, patch) 2014-01-31 00:01 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Writing v2 - Fix style nit. (20.59 KB, patch) 2014-01-31 00:02 PST, Brady Eidson	andersca: review+ andersca: commit-queue-	Details Formatted Diff Diff
Reading patch v1 - Implement with a cursor! (7.21 KB, patch) 2014-02-01 00:15 PST, Brady Eidson	jer.noble: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2014-01-30 23:48:37 PST

This will be done in two separate patches. Index writing is first. It's straightforward and easy to verify by manual debugging and manual inspection on disk that it is working as expected. Index reading will actually be implemented in terms of index cursors later.

Brady Eidson

Comment 2 2014-01-31 00:01:14 PST

Created attachment 222799 [details] Index *writing* patch, v1

WebKit Commit Bot

Comment 3 2014-01-31 00:02:39 PST

Attachment 222799 [details] did not pass style-queue: ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:71: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 4 2014-01-31 00:02:49 PST

Created attachment 222800 [details] Writing v2 - Fix style nit.

Anders Carlsson

Comment 5 2014-01-31 07:47:51 PST

Comment on attachment 222800 [details] Writing v2 - Fix style nit. View in context: https://bugs.webkit.org/attachment.cgi?id=222800&action=review > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:239 > + IDBIndexMetadata idxMetadata; No need to abbreviate index here. > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:256 > + auto objectStoreMetadata = metadata->objectStores.find(objectStoreID); I'd call this objectStoreMetadataIt to indicate that it's an iterator (especially since you're using auto).

Brady Eidson

Comment 6 2014-01-31 07:51:08 PST

http://trac.webkit.org/changeset/163170

Brady Eidson

Comment 7 2014-01-31 07:51:26 PST

Retitling to reflect that only reading remains.

Brady Eidson

Comment 8 2014-02-01 00:15:00 PST

Created attachment 222877 [details] Reading patch v1 - Implement with a cursor!

Jer Noble

Comment 9 2014-02-01 10:48:33 PST

Comment on attachment 222877 [details] Reading patch v1 - Implement with a cursor! View in context: https://bugs.webkit.org/attachment.cgi?id=222877&action=review r=me with obligatory nit. > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:837 > + Ob-nit: Unnecessary whitespace.

Brady Eidson

Comment 10 2014-02-01 11:07:13 PST

http://trac.webkit.org/changeset/163246

Tim Nguyen (:ntim)

Comment 11 2022-03-14 16:36:02 PDT

*** Bug 116223 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.