Bug 127501

Summary: IDB: Implement cross-thread and IPC plumbing for 'get' support
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, andersca, ap, bunhere, commit-queue, gyuyoung.kim, jsbell, rakuco, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 andersca: review+

Brady Eidson
Reported 2014-01-23 12:07:10 PST
IDB: Implement cross-thread and IPC plumbing for 'get' support
Attachments
Patch v1 (39.88 KB, patch)
2014-01-23 12:12 PST, Brady Eidson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-01-23 12:08:29 PST
Implementing actual backing store support of fetching the record is tracked in https://bugs.webkit.org/show_bug.cgi?id=127502, as this patch can easily be reviewed/landed separately.
Brady Eidson
Comment 2 2014-01-23 12:12:54 PST
Created attachment 222012 [details] Patch v1
WebKit Commit Bot
Comment 3 2014-01-23 12:14:35 PST
Attachment 222012 [details] did not pass style-queue: ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:434: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:80: The parameter name "keyRange" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2014-01-23 12:16:50 PST
Comment on attachment 222012 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222012&action=review > Source/WebCore/Modules/indexeddb/IDBKeyRangeData.cpp:43 > + return std::move(result); No need for move here.
Brady Eidson
Comment 5 2014-01-23 12:21:25 PST
http://trac.webkit.org/changeset/162633
Note You need to log in before you can comment on or make changes to this bug.