Bug 126944

<rdar://problem/15002455>

Created attachment 248702 [details] patch

Attachment 248702 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLGetInfo.h:74: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 248703 [details] patch

Attachment 248703 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:38: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/html/canvas/WebGLGetInfo.h:74: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 248704 [details] patch

Attachment 248704 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:38: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/html/canvas/WebGLGetInfo.h:74: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 248704 [details] patch Attachment 248704 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5816189607477248 New failing tests: webgl/1.0.2/conformance/context/context-lost-restored.html fast/canvas/webgl/context-lost-restored.html

Created attachment 248706 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Comment on attachment 248704 [details] patch Attachment 248704 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4664811417763840 New failing tests: webgl/1.0.2/conformance/context/context-lost-restored.html fast/canvas/webgl/context-lost-restored.html

Created attachment 248708 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Created attachment 248709 [details] patch

Attachment 248709 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLGetInfo.h:74: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 248709 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248709&action=review > Source/WebCore/ChangeLog:12 > + This test will be landed along with other modified extension conformance tests > + once approval from Khronos is received. I'm not sure what this means. Do you mean that we plan to contribute this back to Khronos? > Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h:40 > + VaoTypeDefault, > + VaoTypeUser, Can be enum class, and use VAO rather than Vao > Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.cpp:54 > - > + Oops.

(In reply to comment #14) > Comment on attachment 248709 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248709&action=review > > > Source/WebCore/ChangeLog:12 > > + This test will be landed along with other modified extension conformance tests > > + once approval from Khronos is received. > > I'm not sure what this means. Do you mean that we plan to contribute this > back to Kronos? That's the hope. I have a bunch of conformance tests from the test suite that were extension tests but I changed all the calls to treat the extension stuff as core to WebGL2. Hoping to contribute that back to Khronos since their WebGL2 tests right now look like they need some work (looks like they were mostly just copy pasted from a previous suite and then a WebGL2 context was queried...) > > Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h:40 > > + VaoTypeDefault, > > + VaoTypeUser, > > Can be enum class, and use VAO rather than Vao > > > Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.cpp:54 > > - > > + > > Oops.

(In reply to comment #16) > http://trac.webkit.org/changeset/181571 It broke the Apple Windows build as the EWS noticed it in time.

http://trac.webkit.org/changeset/181574 http://trac.webkit.org/changeset/181589

http://trac.webkit.org/changeset/181589 will cause problems. glBindVertexArray et al. are in GLESv3. I carefully made gl2softlinking.h to have everything and only everything that is in GLESv2. It should crash every time it looks for those functions. This change should be reverted and replaced by proper separation of WebGL and WebGL2.

(In reply to comment #19) > http://trac.webkit.org/changeset/181589 will cause problems. > glBindVertexArray et al. are in GLESv3. I carefully made gl2softlinking.h > to have everything and only everything that is in GLESv2. It should crash > every time it looks for those functions. This change should be reverted and > replaced by proper separation of WebGL and WebGL2. Reported on bug 145156 a related regression.