Bug 126409

Summary: CStack LLInt 32-bit should build
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116888    
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2014-01-02 15:10:15 PST
And the stuff we do to make it build should at least try to be correct
Attachments
the patch (13.57 KB, patch)
2014-01-02 15:11 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-01-02 15:11:51 PST
Created attachment 220260 [details] the patch
Filip Pizlo
Comment 2 2014-01-02 15:25:12 PST
Landed in the branch in http://trac.webkit.org/changeset/161234
Michael Saboff
Comment 3 2014-01-02 15:25:39 PST
Comment on attachment 220260 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=220260&action=review r=me, with comments. > Source/JavaScriptCore/ChangeLog:8 > + Description of what you did... > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:165 > const extraStackSpace = 16 This line can be removed. > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:177 > const extraStackSpace = 28 This line can be removed.
Filip Pizlo
Comment 4 2014-01-02 15:50:47 PST
Landed fixes to address Michael's comments in http://trac.webkit.org/changeset/161237
Note You need to log in before you can comment on or make changes to this bug.