Bug 124793

Summary: CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116888    
Attachments:
Description Flags
the patch
mhahnenberg: review+
patch for landing none

Filip Pizlo
Reported 2013-11-22 15:15:57 PST
Patch forthcoming.
Attachments
the patch (19.66 KB, patch)
2013-11-22 15:19 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
patch for landing (20.43 KB, patch)
2013-11-22 16:15 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-11-22 15:19:56 PST
Created attachment 217719 [details] the patch
Mark Hahnenberg
Comment 2 2013-11-22 15:31:11 PST
Comment on attachment 217719 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=217719&action=review r=me > Source/JavaScriptCore/dfg/DFGGraph.cpp:709 > + unsigned count = m_profiledBlock->m_numCalleeRegisters; JIT::frameRegisterCountFor(m_profiledBlock) > Source/JavaScriptCore/dfg/DFGGraph.cpp:713 > + unsigned requiredCount = VirtualRegister(inlineCallFrame->stackOffset).toLocal() + 1 + codeBlock->m_numCalleeRegisters; JIT::frameRegisterCountFor(codeBlock) > Source/JavaScriptCore/dfg/DFGGraph.cpp:715 > + if (requiredCount > count) > + count = requiredCount; max?
Filip Pizlo
Comment 3 2013-11-22 16:15:17 PST
Created attachment 217724 [details] patch for landing
Filip Pizlo
Comment 4 2013-11-22 16:35:48 PST
Landed in http://trac.webkit.org/changeset/159721
Note You need to log in before you can comment on or make changes to this bug.