Bug 124730
| Summary: | check-webkit-style is wrong about expected format for std::function variables | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | Tools / Tests | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, cgarcia, lmoura, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Brady Eidson
check-webkit-style is wrong about expected format for std::function variables.
Seen in the patch(es) attached to https://bugs.webkit.org/show_bug.cgi?id=124698 -
Source/WebKit2/Shared/AsyncRequest.h:60: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/Shared/AsyncRequest.h:78: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/Shared/AsyncRequest.h:89: Extra space before ( in function call [whitespace/parens] [4]
The lines in question are:
static PassRefPtr<AsyncRequest> create(std::function<void (Arguments...)> completionHandler)
AsyncRequestImpl(std::function<void (Arguments...)> completionHandler)
std::function<void (Arguments...)> m_completionHandler;
The style-checker needs to know that when "something that looks like a function decl/def" is inside std::function<> brackets, the space before the paren is expected.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
László Langó
*** Bug 131202 has been marked as a duplicate of this bug. ***
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/25567
EWS
Committed 276122@main (b3871d2a862c): <https://commits.webkit.org/276122@main>
Reviewed commits have been landed. Closing PR #25567 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/124640815>