Bug 124689

Summary: Add argument coders for IDBDatabaseMetadata
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 andersca: review+

Brady Eidson
Reported 2013-11-20 17:00:53 PST
Add argument coders for IDBDatabaseMetadata They will be used shortly for upcoming patches related to https://bugs.webkit.org/show_bug.cgi?id=124521 This is such a separable piece of work it makes it easier to review as a separate patch.
Attachments
Patch v1 (6.63 KB, patch)
2013-11-20 17:03 PST, Brady Eidson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-11-20 17:03:02 PST
Created attachment 217497 [details] Patch v1
WebKit Commit Bot
Comment 2 2013-11-20 17:04:30 PST
Attachment 217497 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/WebCoreArgumentCoders.h']" exit_code: 1 Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-11-20 17:04:39 PST
Comment on attachment 217497 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=217497&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394 > + case IDBKeyPath::StringType: > + { Brace should go on same line as the case. > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1403 > + case IDBKeyPath::ArrayType: > + { Ditto.
Brady Eidson
Comment 4 2013-11-20 17:09:27 PST
http://trac.webkit.org/changeset/159597
Note You need to log in before you can comment on or make changes to this bug.