Bug 124108

Summary: Use child iterator to find operators in RenderMathMLRow::layout().
Product: WebKit Reporter: Andreas Kling <kling>
Component: MathMLAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbarton, eflews.bot, esprehn+autocc, fred.wang, glenn, gtk-ews, gyuyoung.kim, kling, kondapallykalyan, mrobinson, rego+ews, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eflews.bot: commit-queue-
Patch mrobinson: review+, eflews.bot: commit-queue-

Andreas Kling
Reported 2013-11-09 19:37:57 PST
Use child iterator to find operators in RenderMathMLRow::layout().
Attachments
Patch (1.73 KB, patch)
2013-11-09 19:38 PST, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2013-11-09 19:44 PST, Andreas Kling 		mrobinson: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-09 19:38:40 PST
Created attachment 216505 [details] Patch
EFL EWS Bot
Comment 2 2013-11-09 19:43:06 PST
Comment on attachment 216505 [details] Patch Attachment 216505 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22368949
EFL EWS Bot
Comment 3 2013-11-09 19:43:30 PST
Comment on attachment 216505 [details] Patch Attachment 216505 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22728916
Andreas Kling
Comment 4 2013-11-09 19:44:57 PST
Created attachment 216506 [details] Patch
Martin Robinson
Comment 5 2013-11-09 19:47:55 PST
Comment on attachment 216506 [details] Patch All hail, childrenOfType!
EFL EWS Bot
Comment 6 2013-11-09 19:49:55 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22768912
EFL EWS Bot
Comment 7 2013-11-09 19:50:01 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22368952
kov's GTK+ EWS bot
Comment 8 2013-11-09 19:54:34 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22598971
Build Bot
Comment 9 2013-11-09 20:13:49 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22638976
Build Bot
Comment 10 2013-11-09 20:30:21 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/21249024
Build Bot
Comment 11 2013-11-09 20:41:25 PST
Comment on attachment 216506 [details] Patch Attachment 216506 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22868081
Brent Fulgham
Comment 12 2013-11-26 15:52:45 PST
Committed r159794: <http://trac.webkit.org/changeset/159794>
Andreas Kling
Comment 13 2013-11-26 15:54:58 PST
(In reply to comment #12) > Committed r159794: <http://trac.webkit.org/changeset/159794> Oh whoops. I forgot about this one. Thanks for landing it :)
Brent Fulgham
Comment 14 2013-11-26 16:24:01 PST
(In reply to comment #13) > (In reply to comment #12) > > Committed r159794: <http://trac.webkit.org/changeset/159794> > > Oh whoops. I forgot about this one. Thanks for landing it :) Just cleaning up my MathML bug list! I fixed the minor build error with the patch. Build looks good at the moment, with no failures or new problems.
Note You need to log in before you can comment on or make changes to this bug.