Bug 122931

Summary: Transition cti_op_throw and cti_vm_throw to a JIT operation
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 122758    
Attachments:
Description Flags
Patch
none
Updated patch fpizlo: review+

Michael Saboff
Reported 2013-10-16 17:38:21 PDT
Change cti_op_throw to be a JIT operation.
Attachments
Patch (14.33 KB, patch)
2013-10-17 00:18 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated patch (30.97 KB, patch)
2013-10-17 10:23 PDT, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-10-17 00:18:02 PDT
Created attachment 214424 [details] Patch
Filip Pizlo
Comment 2 2013-10-17 07:26:35 PDT
Comment on attachment 214424 [details] Patch Why doesn't this just have the code for op_throw call operationDoThrow directly and then perform the jump from JIT code? Seems like that would be an easier design.
Michael Saboff
Comment 3 2013-10-17 10:23:11 PDT
Created attachment 214468 [details] Updated patch (In reply to comment #2) > (From update of attachment 214424 [details]) > Why doesn't this just have the code for op_throw call operationDoThrow directly and then perform the jump from JIT code? Seems like that would be an easier design. Made this suggested change. Also, since all cti_stubs that had exception checks before returning have been eliminated, I removed cti_vm_throw and it's caller ctiVMThrowTrampoline().
Michael Saboff
Comment 4 2013-10-17 11:11:10 PDT
Committed r157581: <http://trac.webkit.org/changeset/157581>
Note You need to log in before you can comment on or make changes to this bug.