Bug 122645

Summary: Transition misc cti_op_* JITStubs to JIT operations
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122287    
Attachments:
Description Flags
the patch.
msaboff: review-
patch 2: with Michael's feedback applied. msaboff: review+

Mark Lam
Reported 2013-10-11 08:28:13 PDT
Transition these stubs to operations cti_op_check_has_instance cti_op_create_arguments cti_op_del_by_id cti_op_instanceof cti_to_object cti_op_push_activation cti_op_push_name_scope cti_op_push_with_scope cti_op_get_pnames cti_op_load_varargs
Attachments
the patch. (44.34 KB, patch)
2013-10-13 14:49 PDT, Mark Lam 		msaboff: review-
DetailsFormatted DiffDiff
patch 2: with Michael's feedback applied. (43.00 KB, patch)
2013-10-13 23:53 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-10-11 09:02:40 PDT
Michael will take care of cti_op_push_name_scope and cti_push_with_scope in https://bugs.webkit.org/show_bug.cgi?id=122617.
Mark Lam
Comment 2 2013-10-13 14:49:07 PDT
Created attachment 214114 [details] the patch.
Michael Saboff
Comment 3 2013-10-13 23:21:34 PDT
Comment on attachment 214114 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=214114&action=review > Source/JavaScriptCore/jit/CCallHelpers.h:963 > + move(arg2, GPRInfo::argumentGPR2); // In case the incoming arg2 was in argumentGPR1. The comment should actually read "In case arg2 is argumentGPR1". > Source/JavaScriptCore/jit/JIT.h:541 > + void emitGetVirtualRegister(int index, RegisterID tag, RegisterID payload); How is this different than emitLoad(int index, RegisterID tag, RegisterID payload, RegisterID base = callFrameRegister) below? > Source/JavaScriptCore/jit/JITInlines.h:725 > +inline void JIT::emitGetVirtualRegister(int index, RegisterID tag, RegisterID payload) > +{ > + emitLoadTag(index, tag); > + emitLoadPayload(index, payload); > +} Remove, this is the same as inline void JIT::emitLoad(int index, RegisterID tag, RegisterID payload, RegisterID base)
Mark Lam
Comment 4 2013-10-13 23:32:03 PDT
Comment on attachment 214114 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=214114&action=review >> Source/JavaScriptCore/jit/CCallHelpers.h:963 >> + move(arg2, GPRInfo::argumentGPR2); // In case the incoming arg2 was in argumentGPR1. > > The comment should actually read "In case arg2 is argumentGPR1". Will fix. >> Source/JavaScriptCore/jit/JIT.h:541 >> + void emitGetVirtualRegister(int index, RegisterID tag, RegisterID payload); > > How is this different than emitLoad(int index, RegisterID tag, RegisterID payload, RegisterID base = callFrameRegister) below? I was going to say that emitLoad() didn't check for the case where index is referring to a CodeBlock constant, but I was wrong. I was thrown off by the tricky use of (base == callFrameRegister) to indicate that we need to go through emitLoadPayload() and emitLoadTag(). I will fix this. >> Source/JavaScriptCore/jit/JITInlines.h:725 >> +} > > Remove, this is the same as inline void JIT::emitLoad(int index, RegisterID tag, RegisterID payload, RegisterID base) Will do.
Mark Lam
Comment 5 2013-10-13 23:53:02 PDT
Created attachment 214129 [details] patch 2: with Michael's feedback applied.
Michael Saboff
Comment 6 2013-10-14 09:35:20 PDT
Comment on attachment 214129 [details] patch 2: with Michael's feedback applied. View in context: https://bugs.webkit.org/attachment.cgi?id=214129&action=review r+, with whitespace changes. > Source/JavaScriptCore/jit/JITOpcodes.cpp:1047 > + Eliminate this blank line to indicate that the links and subsequent code go together. > Source/JavaScriptCore/jit/JITOpcodes.cpp:1064 > + Dito. > Source/JavaScriptCore/jit/JITOpcodes.cpp:1134 > + Dito.
Mark Lam
Comment 7 2013-10-14 09:41:37 PDT
Thanks for the review. Landed in r157404: <http://trac.webkit.org/r157404>.
Note You need to log in before you can comment on or make changes to this bug.