Bug 122453

Summary: Transition call and construct JITStubs to CCallHelper functions
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 122287    
Attachments:
Description Flags
Patch
none
Patch - fixed style issue ggaren: review+

Michael Saboff
Reported 2013-10-07 11:25:31 PDT
Move the JITStubs cti_op_call_NotJSFunction, cti_op_call_eval, cti_op_construct_NotJSConstruct, cti_op_call_jitCompile and cti_op_construct_jitCompile to CCallHelper functions placing the new function in JITOperations.
Attachments
Patch (37.02 KB, patch)
2013-10-08 21:59 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Patch - fixed style issue (37.01 KB, patch)
2013-10-08 22:05 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-10-07 11:33:29 PDT
Also move cti_vm_lazyLinkCall, cti_vm_lazyLinkConstruct and cti_vm_lazyLinkClosureCall.
Michael Saboff
Comment 2 2013-10-08 21:59:37 PDT
Created attachment 213752 [details] Patch
WebKit Commit Bot
Comment 3 2013-10-08 22:01:17 PDT
Attachment 213752 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CallLinkInfo.cpp', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/JIT.h', u'Source/JavaScriptCore/jit/JITCall.cpp', u'Source/JavaScriptCore/jit/JITCall32_64.cpp', u'Source/JavaScriptCore/jit/JITInlines.h', u'Source/JavaScriptCore/jit/JITOperations.cpp', u'Source/JavaScriptCore/jit/JITOperations.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/jit/ThunkGenerators.h']" exit_code: 1 Source/JavaScriptCore/jit/JITOperations.cpp:469: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/JavaScriptCore/jit/JITOperations.cpp:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 4 2013-10-08 22:05:00 PDT
Created attachment 213754 [details] Patch - fixed style issue
Geoffrey Garen
Comment 5 2013-10-08 22:18:29 PDT
Comment on attachment 213754 [details] Patch - fixed style issue Red is my favorite patch color.
Michael Saboff
Comment 6 2013-10-09 06:28:00 PDT
Committed r157164: <http://trac.webkit.org/changeset/157164>
Note You need to log in before you can comment on or make changes to this bug.