Bug 121287

Summary: ARM EABI hardfp buildfix after r155675
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, mark.lam, msaboff, ossy, youngho33.yoo, zherczeg
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 108645, 117281    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2013-09-13 03:31:40 PDT
http://trac.webkit.org/changeset/155675 added a JSVALUE32_64 implementation of this function: JITCompiler::Call callOperation(V_DFGOperation_EOZD operation, GPRReg arg1, GPRReg arg2, FPRReg arg3) { m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3); ------> !!! return appendCallWithExceptionCheck(operation); } But unfortunately it added only softfp implementation of the following function: ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, TrustedImm32 arg3, FPRReg arg4) We need hardfp implementation too, which should be same as the GPRReg arg1, GPRReg arg2, FPRReg arg3 implementation, but it should simple ignore the dummy third argument. Fix is coming immediately.
Attachments
Patch (1.58 KB, patch)
2013-09-13 03:56 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-09-13 03:56:06 PDT
Created attachment 211531 [details] Patch I got it. It was only a typo. The third argument is the dummy one, not the first one, similar to the call and the softfp implementation.
Geoffrey Garen
Comment 2 2013-09-13 08:27:03 PDT
Comment on attachment 211531 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-09-13 08:54:53 PDT
Comment on attachment 211531 [details] Patch Clearing flags on attachment: 211531 Committed r155705: <http://trac.webkit.org/changeset/155705>
WebKit Commit Bot
Comment 4 2013-09-13 08:54:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.