Bug 120653

Summary: REGRESSION (r154967) window resize is very choppy
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, kling, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2013-09-03 15:36:23 PDT
Window resize with a very simple no-JS testcase is terrible after r154967. People say that tab switching is also impacted.
Attachments
Patch (1.86 KB, patch)
2013-09-03 20:18 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-03 16:09:56 PDT
If the symptom is that bad, maybe we should just roll out! I assume I just got one of the conditions backwards in the patch somewhere, or removed an early return I should not have.
Alexey Proskuryakov
Comment 2 2013-09-03 16:32:21 PDT
If rolling out, r154981 should be rolled out too.
Darin Adler
Comment 3 2013-09-03 19:03:32 PDT
Is this in release builds, or only debug builds?
Darin Adler
Comment 4 2013-09-03 19:04:40 PDT
I tried to find things I did wrong in the patch, especially ones that could possibly have anything to do with window resizing. So far, all I found was bug 120659.
Darin Adler
Comment 5 2013-09-03 20:16:23 PDT
*** Bug 120660 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 6 2013-09-03 20:18:08 PDT
Created attachment 210424 [details] Patch
WebKit Commit Bot
Comment 7 2013-09-03 20:19:26 PDT
Attachment 210424 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp']" exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.cpp:420: Missing spaces around >> [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 8 2013-09-03 20:19:41 PDT
Comment on attachment 210424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210424&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:420 > + HashMap<std::pair<std::pair<StringReference, StringReference>, uint64_t>, OwnPtr<MessageDecoder>>::iterator it = m_waitForMessageMap.find(messageAndDestination); No auto? ;-)
WebKit Commit Bot
Comment 9 2013-09-03 21:26:56 PDT
Comment on attachment 210424 [details] Patch Clearing flags on attachment: 210424 Committed r155017: <http://trac.webkit.org/changeset/155017>
WebKit Commit Bot
Comment 10 2013-09-03 21:26:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.