Bug 116954

Summary:

[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rwlbuis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

96420, 111729

Attachments:

Description	Flags
Patch	rwlbuis: review+, commit-queue: commit-queue-
Rebased patch	none

Carlos Garcia Campos

Reported 2013-05-29 04:15:05 PDT

It's more efficient.

Attachments
Patch (29.56 KB, patch) 2013-05-29 04:17 PDT, Carlos Garcia Campos	rwlbuis: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Rebased patch (29.29 KB, patch) 2013-05-29 10:49 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2013-05-29 04:17:57 PDT

Created attachment 203152 [details] Patch

Rob Buis

Comment 2 2013-05-29 10:18:41 PDT

Comment on attachment 203152 [details] Patch Looks good.

WebKit Commit Bot

Comment 3 2013-05-29 10:36:21 PDT

Comment on attachment 203152 [details] Patch Rejecting attachment 203152 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 203152, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Kit/blackberry/WebKitSupport/AboutData.cpp Hunk #1 FAILED at 67. Hunk #2 succeeded at 194 (offset -1 lines). Hunk #3 succeeded at 226 (offset -1 lines). Hunk #4 succeeded at 248 (offset -1 lines). Hunk #5 succeeded at 418 (offset -1 lines). 1 out of 5 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/AboutData.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/683433

Carlos Garcia Campos

Comment 4 2013-05-29 10:49:05 PDT

Created attachment 203217 [details] Rebased patch

WebKit Commit Bot

Comment 5 2013-05-29 11:36:40 PDT

The commit-queue encountered the following flaky tests while processing attachment 203217 [details]: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/inspect-element.html bug 78869 (author: pfeldman@chromium.org) fast/dom/Window/window-postmessage-clone.html bug 40123 (authors: mrobinson@webkit.org, oliver@apple.com, and vitalyr@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 6 2013-05-29 11:37:33 PDT

Comment on attachment 203217 [details] Rebased patch Clearing flags on attachment: 203217 Committed r150913: <http://trac.webkit.org/changeset/150913>

WebKit Commit Bot

Comment 7 2013-05-29 11:37:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.