Bug 116658

Summary: Path: upstream the missing bits from the BlackBerry port
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
xan.lopez: review-
Patch none

Alberto Garcia
Reported 2013-05-23 04:12:43 PDT
PathBlackBerry was upstreamed a while ago (r144612) but a few bits are missing: - Its definition of PlatformPath. - The declaration of platformAddPathForRoundedRect().
Attachments
Patch (2.75 KB, patch)
2013-05-23 04:14 PDT, Alberto Garcia 		xan.lopez: review-
DetailsFormatted DiffDiff
Patch (2.81 KB, patch)
2013-05-24 09:48 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-05-23 04:14:15 PDT
Created attachment 202660 [details] Patch
Xan Lopez
Comment 2 2013-05-23 06:24:45 PDT
Comment on attachment 202660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202660&action=review > Source/WebCore/platform/graphics/Path.cpp:154 > platformAddPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius); Too bad this is needed, but since CG is doing exactly the same I guess it is acceptable. FWIW this method does not make a lot of sense for the non-CG/non-blackberry ports. They are always going to call 'addBeziersForRoundedRect'. Not sure if it's worth cleaning up in a follow-up though. > Source/WebCore/platform/graphics/Path.h:58 > +typedef BlackBerry::Platform::Graphics::Path PlatformPath; This makes sense. Too bad there seems to be no way to define nested namespaces in one go, it's kinda ugly .though. > Source/WebCore/platform/graphics/Path.h:174 > + Path(const PlatformPath&); This is not used in the patch right? Where is it used exactly?
Alberto Garcia
Comment 3 2013-05-23 10:05:47 PDT
(In reply to comment #2) > > Source/WebCore/platform/graphics/Path.cpp:154 > > platformAddPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius); > > Too bad this is needed, but since CG is doing exactly the same I guess it is acceptable. > > FWIW this method does not make a lot of sense for the non-CG/non-blackberry ports. They are always going to call 'addBeziersForRoundedRect'. Not sure if it's worth cleaning up in a follow-up though. I guess I can try to clean it up in a separate patch. > > Source/WebCore/platform/graphics/Path.h:58 > > +typedef BlackBerry::Platform::Graphics::Path PlatformPath; > > This makes sense. Too bad there seems to be no way to define nested > > namespaces in one go, it's kinda ugly .though. One alternative would be something like namespace BlackBerry { namespace Platform { namespace Graphics { which looks a bit better IMO but I'm not sure if that's accepted style? JSC seems to use something like that... > > Source/WebCore/platform/graphics/Path.h:174 > > + Path(const PlatformPath&); > > This is not used in the patch right? Where is it used exactly? In DefaultTapHighlight::paintContents() at least. Path path(m_region.boundaryPath());
Xan Lopez
Comment 4 2013-05-24 09:43:29 PDT
Comment on attachment 202660 [details] Patch I see a bunch of uses of the namespace FOO { namspace BAR { thing in Webcore too, so probably best to do that (I think it looks better). And also good to do the cleanup after this, I think. r- for the style thing.
Alberto Garcia
Comment 5 2013-05-24 09:48:14 PDT
Created attachment 202830 [details] Patch So be it
WebKit Commit Bot
Comment 6 2013-05-24 10:28:17 PDT
Comment on attachment 202830 [details] Patch Clearing flags on attachment: 202830 Committed r150646: <http://trac.webkit.org/changeset/150646>
WebKit Commit Bot
Comment 7 2013-05-24 10:28:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.